Closed
Bug 1445090
Opened 7 years ago
Closed 7 years ago
Remove strings that are unused at the end of 61
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Mardak, Assigned: dmosedale)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Similar to bug 1433209 that cleaned up at the end of 60. We want to clean up strings once we no longer need to uplift strings to beta (60) -- i.e., after "final locale check".
We should reference this bug when landing commits that makes a string unused but can't remove it yet.
Reporter | ||
Updated•7 years ago
|
Severity: normal → enhancement
Reporter | ||
Comment 1•7 years ago
|
||
[github robot]
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/d301c0e31298c803731efd870359c69c58033a65
feat(preferences): Add preferences to about:preferences when it loads (#4015)
Fix Bug 1404890 - Move new tab settings for sections to about:preferences
Bug 1445090 - These strings are probably unused: pocket_description, settings_pane_topstories_options_sponsored, settings_pane_highlights_body2
Comment 2•7 years ago
|
||
The following are strings IDs for strings that are unused and should be removed:
settings_pane_header
settings_pane_body2
settings_pane_search_header
settings_pane_search_body
settings_pane_topsites_header
settings_pane_topsites_body
settings_pane_topsites_options_showmore
settings_pane_highlights_header
settings_pane_highlights_options_bookmarks
settings_pane_highlights_options_visited
settings_pane_snippets_header
settings_pane_snippets_body
settings_pane_done_button
Updated•7 years ago
|
Priority: -- → P2
Reporter | ||
Comment 3•7 years ago
|
||
https://github.com/mozilla/activity-stream/pull/4111 added a new string "Visited Pages" leaving settings_pane_highlights_options_visited=Visited Sites unused
Reporter | ||
Comment 4•7 years ago
|
||
Pretty sure `prefs_restore_defaults_button=Restore Defaults` ended up not being used as it landed as fluent in m-c home-restore-defaults in bug 1417155.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dmose
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Ed Lee :Mardak from comment #1)
> Fix Bug 1404890 - Move new tab settings for sections to about:preferences
>
> Bug 1445090 - These strings are probably unused: pocket_description,
> settings_pane_topstories_options_sponsored, settings_pane_highlights_body2
Removing pocket_description.
The settings_pane strings listed above are already gone.
Assignee | ||
Comment 6•7 years ago
|
||
My mistake, the two settings_pane* strings mentioned above have not yet been removed; I'll remove them as well.
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Ursula Sarracini (:ursula) from comment #2)
> The following are strings IDs for strings that are unused and should be
> removed:
>
> settings_pane_header
> settings_pane_body2
Removing.
> settings_pane_search_header
Already removed.
> settings_pane_search_body
Removing.
> settings_pane_topsites_header
Still used in AboutPreferences.jsm; leaving alone.
> settings_pane_topsites_body
> settings_pane_topsites_options_showmore
Removed.
> settings_pane_highlights_header
> settings_pane_highlights_options_bookmarks
Still used in SectionsManager.jsm; leaving alone.
> settings_pane_highlights_options_visited
Removed.
> settings_pane_snippets_header
Still used in AboutPreferences.jsm; leaving alone.
> settings_pane_snippets_body
> settings_pane_done_button
Removed.
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Ed Lee :Mardak from comment #3)
> https://github.com/mozilla/activity-stream/pull/4111 added a new string
> "Visited Pages" leaving settings_pane_highlights_options_visited=Visited
> Sites unused
Already removed.
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Ed Lee :Mardak from comment #4)
> Pretty sure `prefs_restore_defaults_button=Restore Defaults` ended up not
> being used as it landed as fluent in m-c home-restore-defaults in bug
> 1417155.
Removing.
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/f5ffc3fb9f0f5845339d58ee638e84a9172e302a
chore(l10n): remove unused strings to ease l10n work (#4140)
Fix Bug 1445090 - Remove strings that are unused at the end of 61
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•7 years ago
|
||
Target Milestone: --- → Firefox 61
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•