PlaceBackup.jsm has some code that was deprecated in bug 859695, now that add-ons are no longer able to access it, we should remove the old code. The deprecation was due to OS.File adoption. There's also some double-handling of backup file lists, so we can simplify that as well.

Comment on attachment 8946318 [details] Bug 1433979 - Remove deprecated code from PlacesBackups.jsm as it is no longer necessary. https://reviewboard.mozilla.org/r/216296/#review222718 nice one! ::: browser/components/places/content/places.js:536 (Diff revision 1) > let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker); > let fpCallback = function fpCallback_done(aResult) { > if (aResult != Ci.nsIFilePicker.returnCancel) { > // There is no OS.File version of the filepicker yet (Bug 937812). > - PlacesBackups.saveBookmarksToJSONFile(fp.file.path); > + PlacesBackups.saveBookmarksToJSONFile(fp.file.path) > + .catch(Cu.reportError); nit: please align dots ::: toolkit/components/places/PlacesBackups.jsm:20 (Diff revision 1) > XPCOMUtils.defineLazyModuleGetter(this, "BookmarkJSONUtils", > "resource://gre/modules/BookmarkJSONUtils.jsm"); > -XPCOMUtils.defineLazyModuleGetter(this, "Deprecated", > - "resource://gre/modules/Deprecated.jsm"); > XPCOMUtils.defineLazyModuleGetter(this, "OS", > "resource://gre/modules/osfile.jsm"); please use defineLazyModuleGetters, and also include PlacesUtils into it.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5600d2ea770 Remove deprecated code from PlacesBackups.jsm as it is no longer necessary. r=mak