Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 SeaMonkey/2.25a1 (BuildID: 20131124011553) When opening e.g. Tools > Add-ons Manager I get various deprecation errors in console: Error: DEPRECATION WARNING: PlacesBackups.getMostRecent is deprecated and will be removed in a future version. You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695 resource://gre/modules/PlacesBackups.jsm 194 PB_getMostRecent resource://gre/components/nsSuiteGlue.js 710 null resource://gre/components/nsSuiteGlue.js 196 null Error: DEPRECATION WARNING: PlacesBackups.entries is deprecated [...] Error: DEPRECATION WARNING: PlacesBackups.folder is deprecated [...]

(In reply to Stefan Sitter from comment #0) > Error: DEPRECATION WARNING: PlacesBackups.entries is deprecated [...] > > Error: DEPRECATION WARNING: PlacesBackups.folder is deprecated [...] At least as far as the nsSuiteGlue.js:710 occurrence is concerned, these are only due to getMostRecent() being called in the first place. Otherwise, all this is just trying to tell us that we need to port bug 859695. Since that has TM mozilla27, I guess any SM version beginning with 2.24 (now on Beta) is affected (by the deprecation warnings; nothing has been removed yet, not even on trunk).

[Mozilla/5.0 (Windows NT 6.0; rv:33.0) Gecko/20100101 Firefox/33.0 SeaMonkey/2.30; 20141013232806] { Erreur : DEPRECATION WARNING: PlacesBackups.getMostRecent is deprecated and will be removed in a future version You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695 resource://gre/modules/PlacesBackups.jsm 263 PB_getMostRecent resource://gre/components/nsSuiteGlue.js 723 SuiteGlue.prototype._initPlaces resource://gre/components/nsSuiteGlue.js 199 SuiteGlue.prototype.observe null 0 null Fichier Source : resource:///modules/Deprecated.jsm Ligne : 79 }

Note: this code is going away in bug 1433979 - likely to land in the next day or so. It should be easy to copy from nsBrowserGlue.js where this affects, although you might need to check for other call locations.

Thanks. I did a wip patch some time ago. Will look into it.

part 1 for sports

part 2 breakage fix

2.53 version part 1

2.53 version part 2

Should we keep the lock strings in notification.properties or match Fx as in this bug? Not an exact match because we show a notification but otherwise almost identical.

Rebased after Bug 1436605 landed.

Rebased after Bug 1436605 landed.

(In reply to Frank-Rainer Grahl (:frg) from comment #9) > Should we keep the lock strings in notification.properties or match Fx as in > this bug? Not an exact match because we show a notification but otherwise > almost identical. Having them just in places.properties is fine.

Comment on attachment 8955778 [details] [diff] [review] 942937-part1-profileshutdown-257.patch [Approval Request Comment] Regression caused by (bug #): Bug 967839 User impact if declined: bookmarks backup not working possible startup crash Testing completed (on m-c, etc.): 2.53 Risk to taking this patch (and alternatives if risky): -- String changes made by this patch: --

Comment on attachment 8955779 [details] [diff] [review] 942937-part2-placesinit-257.patch [Approval Request Comment] Regression caused by (bug #): Bug 967839 User impact if declined: bookmarks backup not working possible startup crash Testing completed (on m-c, etc.): 2.53 Risk to taking this patch (and alternatives if risky): -- String changes made by this patch: --

Comment on attachment 8955779 [details] [diff] [review] 942937-part2-placesinit-257.patch Regression actually cuased by Bug 1433979. Comment is correct.

Comment on attachment 8955778 [details] [diff] [review] 942937-part1-profileshutdown-257.patch LGTM r/a=me

Comment on attachment 8955779 [details] [diff] [review] 942937-part2-placesinit-257.patch LGTM r/a=me

Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/aad618543d32 Move onProfileShutdown logic to quit-application-granted phase. r=IanN https://hg.mozilla.org/comm-central/rev/1ad208ac3369 Clean up places init and remove deprecated PlacesBackups calls. r=IanN

https://hg.mozilla.org/releases/comm-beta/rev/85fef84f3604 https://hg.mozilla.org/releases/comm-beta/rev/e7ec4d4f2a40