Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Reporter
	Description • 7 years ago

Instant Messaging of Thunderbird still uses nsIDOMWindowUtils.sendKeyEvent() which was marked obsolete for several years ago:
https://searchfox.org/comm-central/source/im/content/conversation.xml#1055
https://searchfox.org/comm-central/source/im/content/tabbrowser.xml#318
https://searchfox.org/comm-central/source/mail/components/im/content/imconv.xml#259
https://searchfox.org/comm-central/source/mail/components/im/content/imconversation.xml#976

This will be removed completely (if it's possible, at 60). So, please rewrite them with nsITextInputProcessor ASAP. EventUtils.js must be a good reference to use it:
https://searchfox.org/mozilla-central/rev/97cb0aa64ae51adcabff76fb3b5eb18368f5f8ab/testing/mochitest/tests/SimpleTest/EventUtils.js#835-905
https://searchfox.org/mozilla-central/rev/97cb0aa64ae51adcabff76fb3b5eb18368f5f8ab/testing/mochitest/tests/SimpleTest/EventUtils.js#1248-1269

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Reporter
	Comment 1 • 7 years ago

FYI: Even if this bug won't be fixed by next weekend, I'll get rid of the legacy API on 12th Feb.

	Richard Marti (:Paenglab)
	Comment 2 • 7 years ago

Martin, maybe you could look into it?

	Jorg K (CEST = GMT+2)
	Comment 3 • 7 years ago

Or Aceman ;-)

	:aceman
	Comment 4 • 7 years ago

Yeah, maybe. Do we need to care for the /im/ files or are those dead?

	Florian Quèze [:florian]
	Comment 5 • 7 years ago

(In reply to :aceman from comment #4)
> Yeah, maybe. Do we need to care for the /im/ files or are those dead?

Dead enough that we don't need to fix it there.

	Jorg K (CEST = GMT+2)
	Comment 6 • 7 years ago

As of yesterday, IB won't build any more, see bug 1434515 comment #7.

	:aceman
	Comment 7 • 7 years ago

I never know if that /im directory contains the chat backend and mail/components/im is some glue to make chat work in TB. Or if /im is glue to make a standalone Instantbird. It would be useful to remove (or mark) unneeded files.

	Florian Quèze [:florian]
	Comment 8 • 7 years ago

im/ is the Instantbird UI
mail/components/im is the Thunderbird Chat UI
chat/ is the chat back-end, shared between Instantbird and Thunderbird (like mailnews is shared between TB and SeaMonkey).

We'll remove im/ at some point (bug 1410739), but while we still have some features working in Instantbird and not ported to Thunderbird chat yet, it's still nice to be able to find the code in searchfox.

	:aceman
	Comment 9 • 7 years ago

OK, so chat/ is the backend, thanks.

	Martin Giger [:freaktechnik] Assignee
	Comment 10 • 7 years ago

Simplest solution: just dispatch DOM events on the input field instead of doing fancy other stuff that doesn't work.

	:aceman
	Comment 11 • 7 years ago

Comment on attachment 8948064 [details] [diff] [review]
bug1434317.patch

Review of attachment 8948064 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I would never arrive at this because I don't really know what the IM code tries to do.

	Jorg K (CEST = GMT+2)
	Comment 12 • 7 years ago

Thanks from me, too :-)

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Reporter
	Comment 13 • 7 years ago

Reminder: I'll drop the API on the next Monday or Tuesday.

	Jorg K (CEST = GMT+2)
	Comment 14 • 7 years ago

Thanks, we're aware of it. Florian, can you please review the patch.

	Florian Quèze [:florian]
	Comment 15 • 7 years ago

Comment on attachment 8948064 [details] [diff] [review]
bug1434317.patch

Looks good and works well, thanks!

	Jorg K (CEST = GMT+2)
	Comment 16 • 7 years ago

Thanks, I'll land this tonight.

	Pulsebot
	Comment 17 • 7 years ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b0c82d15482c
Use DOM event dispatching to replace nsIDOMWindowUtils.sendKeyEvent(). r=florian