Closed
Bug 1439995
Opened 7 years ago
Closed 6 years ago
Missing user prompt handling for Execute Script and Execute Async Script
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ato, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1279211.
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ato)
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8953040 [details] Bug 1439995 - Add user prompt checks for script execution commands. https://reviewboard.mozilla.org/r/222316/#review228204
Attachment #8953040 -
Flags: review?(dburns) → review+
Reporter | ||
Comment 5•7 years ago
|
||
I’m going to delay this until bug 1264259 because it creates some difficult problems with WPT.
Reporter | ||
Updated•7 years ago
|
Attachment #8953040 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8995334 -
Flags: review?(ato)
Attachment #8995335 -
Flags: review?(ato)
Reporter | ||
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8995334 [details] Bug 1439995 - [marionette] Add user prompt checks for script execution commands. https://reviewboard.mozilla.org/r/259792/#review266894
Attachment #8995334 -
Flags: review?(ato) → review+
Reporter | ||
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8995335 [details] Bug 1439995 - [wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script. https://reviewboard.mozilla.org/r/259794/#review266896
Attachment #8995335 -
Flags: review?(ato) → review+
Comment 12•6 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fcc35eafe56 [marionette] Add user prompt checks for script execution commands. r=ato https://hg.mozilla.org/integration/autoland/rev/910af1264f68 [wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12210 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/12210 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/408892579?utm_source=github_status&utm_medium=notification)
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fcc35eafe56 https://hg.mozilla.org/mozilla-central/rev/910af1264f68
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR merged
Assignee | ||
Updated•4 years ago
|
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•