This bug should track the work to get all the remaining user prompt tests added. Once I'm back from PTO I will file individual bugs for each command, and make those most likely mentored bugs. The steps should be the following: 1) There are commands which already have user prompt tests but those are not fully done yet. Complete those first. 2) Take existing user prompt tests as template to get the tests added for all the remaining commands.

Well, lets not keep this bug as meta bug but let me just add all those tests. If new dependencies will appear, I will still mark them as such.

Please note that we cannot add those tests yet for Element Click and Element Clear due to: https://github.com/w3c/webdriver/issues/1191 Or we just go ahead and land them for test coverage to make the WebDriver spec change?

Have you considered submitting a patch for the spec to see if that generates some feedback from other vendors? If there is a continued lack of responsiveness I suggest that we go ahead and do the Right Thing. But you’re right of course that the spec needs to be updated to be inline with the tests first.

(In reply to Andreas Tolfsen ❲:ato❳ from comment #3) > Have you considered submitting a patch for the spec to see if that > generates some feedback from other vendors? Not yet. But I did it now: https://github.com/w3c/webdriver/pull/1303

Please note that I cannot add those tests for all the commands given that there is some uncertainty. See https://github.com/w3c/webdriver/issues/1086. As such I will add as many as I can.

This adds the user prompt tests for those commands which clearly have to handle the prompt. But it still leaves out those commands where the behavior hasn't been clarified yet.

Comment on attachment 9012222 [details] Bug 1473814 - [wdspec] Add user prompt tests for more WebDriver commands. Andreas Tolfsen ❲:ato❳ has approved the revision.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8d681cc1d4c [wdspec] Add user prompt tests for more WebDriver commands. r=ato

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13232 for changes under testing/web-platform/tests

Backed out changeset f8d681cc1d4c (Bug 1473814) for marionette failures on /marionette_harness/tests/unit/test_switch_frame.py. Backout: https://hg.mozilla.org/integration/autoland/rev/79dd086c938e6bf40ceb8674b4de9025050e511a Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending,running,success,testfailed,busted,exception&revision=f8d681cc1d4cdd5095853077c0acc95576baa6dd&selectedJob=201813961 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=201813961&repo=autoland&lineNumber=24573

Upstream PR was closed without merging

Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13232 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/433808491?utm_source=github_status&utm_medium=notification) * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Z1G5wGfQSLGBHTzS5Mk3_A)

Oh, I have no idea how a change to testing/marionette/harness/marionette_harness/tests/unit/test_switch_frame.py has been sneaked in here. We didn't even notice that in the review cycle. Sorry for that. I'm going to remove that file and the changes for MANIFEST.json before pushing again.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9b9e65f068 [wdspec] Add user prompt tests for more WebDriver commands.

Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13232 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/433942489?utm_source=github_status&utm_medium=notification) * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/VhuFgobrQ_iPmFlVitOMEg)