Closed
Bug 1441668
Opened 7 years ago
Closed 5 years ago
editMenuOverlay.xul removal
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.53 unaffected, seamonkey2.57esr affected)
RESOLVED
FIXED
seamonkey 2.74
Tracking | Status | |
---|---|---|
seamonkey2.53 | --- | unaffected |
seamonkey2.57esr | --- | affected |
People
(Reporter: bdahl, Assigned: frg)
References
(Blocks 3 open bugs)
Details
Attachments
(2 files, 5 obsolete files)
(deleted),
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
A heads up...over in bug 1439766 I will be removing editMenuOverlay.xul.
Assignee | ||
Updated•7 years ago
|
Blocks: 2.57BulkMalfunctions
status-seamonkey2.57esr:
--- → affected
Assignee | ||
Comment 1•7 years ago
|
||
Might work but need to check if we need to move individual keys. Really bad compared to just including the overlay but can't be helped. If someone else wants to finish it be my guest.
Assignee | ||
Comment 2•6 years ago
|
||
Rebased 2.57 wip patch
Attachment #8967556 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Rebased c-c wip patch
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
comm-central version
Attachment #8985854 -
Attachment is obsolete: true
Comment on attachment 9140551 [details] [diff] [review]
1441668-editmenuoverlay-257.patch
The only place that still seems to need editMenuOverlay.dtd is placesOverlay.xul, so it can be removed from the rest of the code:
>+++ b/suite/components/console/content/console.xul
> <!DOCTYPE window [
> <!ENTITY % console SYSTEM "chrome://communicator/locale/console/console.dtd"> %console;
>+ <!ENTITY % editMenuDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd"> %editMenuDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE window SYSTEM...
>+++ b/suite/components/downloads/content/downloadmanager.xul
> <!DOCTYPE window [
> <!ENTITY % downloadsDTD SYSTEM "chrome://communicator/locale/downloads/downloadmanager.dtd">
> %downloadsDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.
>+++ b/suite/components/places/content/history-panel.xul
> <!DOCTYPE page [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
>+<!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
>+ %editMenuOverlayDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE page SYSTEM...
>+++ b/suite/components/places/content/places.xul
> <!DOCTYPE window [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.
r/a=me with those addressed.
Attachment #9140551 -
Flags: review+
Attachment #9140551 -
Flags: approval-comm-esr60+
Comment on attachment 9140553 [details] [diff] [review]
1441668-editmenuoverlay-cc.patch
Same comments as for the other patch, r =me with those addressed.
Attachment #9140553 -
Flags: review+
Assignee | ||
Comment 8•5 years ago
|
||
Updated comm-central patch r+ from IanN retained. Additional fixes as discussed via irc.
Attachment #9140553 -
Attachment is obsolete: true
Attachment #9140828 -
Flags: review+
Assignee | ||
Comment 9•5 years ago
|
||
Updated 2.57 patch. r/a+ from IanN retained. Additional fixes as discussed via irc.
Attachment #9140551 -
Attachment is obsolete: true
Attachment #9140829 -
Flags: review+
Attachment #9140829 -
Flags: approval-comm-esr60+
Comment 10•5 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e0aed4844492
Replace editMenuOverlay.xul in SeaMonkey with preprocessed includes. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
status-seamonkey2.53:
--- → unaffected
Target Milestone: --- → seamonkey 2.74
Version: unspecified → Trunk
Comment 11•4 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7e0a7e7cf046
Follow-up fix build bustage. r=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•