Closed
Bug 1443315
Opened 7 years ago
Closed 7 years ago
Ensure preloaded about:newtab always has layers ready to avoid white flash when opening new tabs
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxperf:p1])
Attachments
(2 files)
This is similar to bug 1389546, but can be made simpler now that we have renderLayers separated from docShellIsActive. Essentially, for preloaded about:newtab's, I think we can have their layers always being rendered in the background, and this should allow us to avoid the annoying white flash we see when opening new tabs.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8956239 [details] Bug 1443315 - Make preloaded about:newtab's layers always rendered so that we avoid the flash when opening new tabs. https://reviewboard.mozilla.org/r/225148/#review231122 Seems reasonable, but I wonder how we can verify that this has the intended effect. Do you have steps to reproduce for this specific white flash? Is this something we should verify on a video recording on the ref hardware? Can we have flicker tests for it?
Attachment #8956239 -
Flags: review?(florian) → review+
Updated•7 years ago
|
Component: New Tab Page → Activity Streams: Newtab
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Component: Activity Streams: Newtab → Tabbed Browser
Priority: -- → P3
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8956239 [details] Bug 1443315 - Make preloaded about:newtab's layers always rendered so that we avoid the flash when opening new tabs. https://reviewboard.mozilla.org/r/225148/#review231592 ::: browser/base/content/tabbrowser.js:1816 (Diff revision 2) > } > > browser.loadURI(BROWSER_NEW_TAB_URL); > browser.docShellIsActive = false; > + browser.renderLayers = true; > + browser._urlbarFocused = true; Why is this needed and what does this have to do with this bug?
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8956602 [details] Bug 1443315 - Don't set docShellIsActive to false for preloaded browsers that are being inserted. https://reviewboard.mozilla.org/r/225530/#review231594
Attachment #8956602 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8956239 [details] Bug 1443315 - Make preloaded about:newtab's layers always rendered so that we avoid the flash when opening new tabs. https://reviewboard.mozilla.org/r/225148/#review231592 > Why is this needed and what does this have to do with this bug? This is needed to avoid a test failure where the URL bar isn't focused in time by the time the tab switch completes.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/416654775d77 Make preloaded about:newtab's layers always rendered so that we avoid the flash when opening new tabs. r=florian https://hg.mozilla.org/integration/autoland/rev/c5bcdb85fb8d Don't set docShellIsActive to false for preloaded browsers that are being inserted. r=dao
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/416654775d77 https://hg.mozilla.org/mozilla-central/rev/c5bcdb85fb8d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•