User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.167 Chrome/64.0.3282.167 Safari/537.36 Steps to reproduce: Firefox 59 rev62 from the snap store fails to load theme assets.

Comment on attachment 8956488 [details] Bug 1443522 - Fix mime cache generation which was breaking themes https://reviewboard.mozilla.org/r/225408/#review231316 LGTM. Please let me know if `mime-handler.xml` still has some use or not. ::: taskcluster/docker/firefox-snap/snapcraft.yaml.in (Diff revision 1) > - shared-mime-info > build-attributes: [no-system-libraries] > install: | > set -eux > - mkdir -p $SNAPCRAFT_PART_INSTALL/usr/share/mime/packages > - install -m 644 mime-handler.xml $SNAPCRAFT_PART_INSTALL/usr/share/mime/packages Do we still need mime-handler.xml to be versioned?

Comment on attachment 8956488 [details] Bug 1443522 - Fix mime cache generation which was breaking themes https://reviewboard.mozilla.org/r/225408/#review231316 I'd like to leave it for now, in case our xdg-open solution still requires that. If it doesn't, I'll include removal of this file in that branch.

Comment on attachment 8956488 [details] Bug 1443522 - Fix mime cache generation which was breaking themes https://reviewboard.mozilla.org/r/225408/#review231358 Sounds good to me.

Comment on attachment 8956488 [details] Bug 1443522 - Fix mime cache generation which was breaking themes Approval Request Comment [Feature/Bug causing the regression]: None [User impact if declined]: Unable to ship the first Snap release. Snaps are a new package format powered by Canonical. [Is this code covered by automated tests?]: N/A [Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release. [Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product. [String changes made/needed]: None.

Pushed by jlorenzo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76c828bf2d03 Fix mime cache generation which was breaking themes r=jlorenzo

Comment on attachment 8956488 [details] Bug 1443522 - Fix mime cache generation which was breaking themes Approved for 59rc2.

Landed on release at: https://hg.mozilla.org/releases/mozilla-release/rev/0370af216a0b6b3d64db885704d245d10b71a396