Closed Bug 1444207 Opened 7 years ago Closed 7 years ago

Consolidate failure_summary_panel to /details-panel

Categories

(Tree Management :: Treeherder: Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

References

Details

Attachments

(1 file)

This includes moving the file and renaming it. This also includes merging as much "controller" code into the component itself as is appropriate/possible.
Assignee: nobody → cdawson
Comment on attachment 8958842 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3341 Sorry this one is somewhat more involved than the others. It's a more complex panel and I hit some gotchas with hosting React within Angular. So Once I convert the last of the bottom panel to React, I'll be able to better delegate some code responsibility.
Attachment #8958842 - Flags: review?(emorley)
Attachment #8958842 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/50034a713bd753811096f4df1efb692be6bf0033 Bug 1444207 - Consolidate failure_summary_panel to /details-panel (#3341) * Rename the component to a *Tab and move to /details-panel folder * cleanup indentation * cleanup props and panel elements * Use deconstruction for props object * simplify onclick event calls with anonymous functions * Move filerInAddress logic to FailureSummaryTab * Move the data-fetching into the main controller like the other tabs so we can do away with the special controller for the failure summary tab. * Move functions to helpers instead of filters and take less values as params * Eliminate failure_summary/controller * Moved logic to either the parent controller or into helpers and the FailureSummaryTab * Use helper function for bugzilla url
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1447787
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: