Open Bug 1446380 Opened 7 years ago Updated 1 year ago

mozharness should report NS_ERROR assertion failure lines as log level ERROR

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

enhancement

Tracking

(Not tracked)

People

(Reporter: nbp, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached file Failing job sample (deleted) —
pretty log: https://treeherder.mozilla.org/logviewer.html#?job_id=168234154&repo=try&lineNumber=11543 raw log: https://taskcluster-artifacts.net/ELikuFNHQPql5Ir8at7-Yg/0/public/logs/live_backing.log Some assertions failures are reported, and even reporting a stack but they do not kill the process, such as NS_ERROR macro. These assertions might be related to some processes remaining idle, which not reported in the summary either. I think we should report these assertions on tree-herder, in addition to other TEST-UNEXPECTED-FAIL messages.
Hi! Presuming this error doesn't appear in cases where the job is meant to still pass, then yeah I agree it would be good to get these line appearing in the error summary. We're no longer accepting regex changes in Treeherder for cases where the test harness/runner should be using appropriate log line prefixes, so in this case mozharness will need changing to make: 16:56:43 INFO - ...be output as: 16:56:43 ERROR - I think that happens via this file: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/errors.py
Blocks: 778688
Component: Treeherder: Log Parsing & Classification → Mozharness
Product: Tree Management → Release Engineering
QA Contact: catlee
Summary: No faulty line suggestion when an NS_ERROR assertion failure is reported. → mozharness should report NS_ERROR assertion failure lines as log level ERROR
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: