Closed Bug 1448394 Opened 7 years ago Closed 7 years ago

The "g" letter is cut off in Recommended by Pocket "Trending" status

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 61
Iteration:
61.2 - Apr 9
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 + verified
firefox61 --- verified

People

(Reporter: JuliaC, Assigned: rrosario)

References

Details

(Keywords: regression)

User Story

https://github.com/mozilla/activity-stream/compare/firefox-60b3...9a8627f9feb0747f85b2dbc3cf6bdf616829ebfc

Attachments

(2 files)

[Affected versions]: - 61.0a1 (2018-03-22) - 60.0b6 build1 (20180322152034) [Affected platforms]: - Windows 10 x64 - macOS 10.13.3 [Steps to reproduce]: 1. Launch Firefox 2. Make sure that the Recommended by Pocket section is enabled 3. Inspect the cards "Trending" status [Expected result]: - The "Trending" status is properly displayed [Actual result]: - The "g" letter is cut off in the "Trending" status (see the screenshot https://tinyurl.com/yd63gxqn) [Regression range]: - last good revision: 4fdc36aa477ab82cf107b39bed490d9f5080dd9c - first bad revision: f1965cf7425fe422c9e9c78018f11b97e0a0f229 - pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4fdc36aa477ab82cf107b39bed490d9f5080dd9c&tochange=f1965cf7425fe422c9e9c78018f11b97e0a0f229 - it's possible that bug 1443928 to regress this issue [Additional notes]: - Ubuntu platform is not affected
:juliaC will the fix for this need to be uplifted to Fx60 beta?
Iteration: --- → 61.2 - Apr 9
Flags: needinfo?(iulia.cristescu)
Priority: -- → P2
Assignee: nobody → rrosario
(In reply to Tim Spurway [:tspurway] from comment #1) > :juliaC will the fix for this need to be uplifted to Fx60 beta? If this is possible, it will be a noticeable UI improvement. The issue is not a blocker, but in my opinion it can easily be annoying in terms of UX.
Flags: needinfo?(iulia.cristescu)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Mardak: I guess we want to uplift this one to beta. I can help :)
Flags: needinfo?(edilee)
Blocks: 1449792
We'll let this land on nightly first before requesting uplift.
User Story: (updated)
Depends on: 1444522
Comment 2 suggests potentially uplifting this fix to 60.
Blocks: 1447752
User Story: (updated)
Flags: needinfo?(edilee)
Flags: needinfo?(edilee)
r1cky, could you export the current firefox-60 branch (9a8627f9feb0747f85b2dbc3cf6bdf616829ebfc) against the current mozilla-beta? I can help walk through the steps if you haven't got a mozilla-beta set up yet. Would also be good to get this verified on Nightly 61 before uplift.
Flags: needinfo?(edilee) → needinfo?(rrosario)
Flags: qe-verify+
Comment on attachment 8964375 [details] Bug 1448394 - The "g" letter is cut off in Recommended by Pocket "Trending" status. https://reviewboard.mozilla.org/r/233090/#review238520
Attachment #8964375 - Flags: review?(edilee) → review+
I can confirm that the bug is now verified fixed on 61.0a1 (2018-04-03), using Windows 10 x64 and macOS 10.13.3.
Status: RESOLVED → VERIFIED
Comment on attachment 8964375 [details] Bug 1448394 - The "g" letter is cut off in Recommended by Pocket "Trending" status. Approval Request Comment [Feature/Bug causing the regression]: Wide layout bug 1385944 missing a style [User impact if declined]: Potentially poor display of "type" text on cards (stories, highlights) [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes, comment 12 [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: This needs to land before 1447752 just as an artifact of how we export changes. [Is the change risky?]: No [Why is the change risky/not risky?]: Minor css change for wide layout to give more space to show the full text. The exported change is large due to per-platform styles and source .map files, but the original source change is small: https://github.com/mozilla/activity-stream/commit/9a8627f9feb0747f85b2dbc3cf6bdf616829ebfc [String changes made/needed]: None
Flags: needinfo?(rrosario)
Attachment #8964375 - Flags: approval-mozilla-beta?
Comment on attachment 8964375 [details] Bug 1448394 - The "g" letter is cut off in Recommended by Pocket "Trending" status. activity stream css fix, approved for 60.0b10
Attachment #8964375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
There are many conflicts with the beta tree, please provide a patch which applies and also verify that the central revision from bug 1447752 applies cleanly. Thank you in advance.
Flags: needinfo?(rrosario)
aryx, the patch seems to apply cleanly for me against latest mozilla-beta: HEAD is now at a425705b63e5 Bug 1425197 - Add additional checks of the target URL in the inspectedWindow devtools actor. r=kmag, r=ochameau a=jcristau mozilla-central$ curl https://reviewboard.mozilla.org/r/233090/diff/raw/ | patch -p1 patching file browser/extensions/activity-stream/css/activity-stream-linux.css patching file browser/extensions/activity-stream/css/activity-stream-linux.css.map patching file browser/extensions/activity-stream/css/activity-stream-mac.css patching file browser/extensions/activity-stream/css/activity-stream-mac.css.map patching file browser/extensions/activity-stream/css/activity-stream-windows.css patching file browser/extensions/activity-stream/css/activity-stream-windows.css.map patching file browser/extensions/activity-stream/install.rdf.in
Flags: needinfo?(aryx.bugmail)
Flags: needinfo?(rrosario)
Flags: needinfo?(aryx.bugmail)
The fix is also successfully applied on 60.0b10 build1 (20180404171943), using Windows 10 x64 and macOS 10.13.3.
Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: