Closed
Bug 1447752
Opened 7 years ago
Closed 7 years ago
Search bar colour fill is wrong in Nightly
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
People
(Reporter: amylee, Assigned: rrosario)
References
Details
User Story
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-review-board-request
|
Mardak
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
The fill colour for the search bar should be #FFFFFF. Right now it's the same colour as the New Tab background colour (#f9f9fa) so it looks disabled.
Comment 1•7 years ago
|
||
Ah doh, pretty sure this regressed from bug 1418090. https://github.com/mozilla/activity-stream/pull/3982
Depends on: 1418090
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rrosario
Updated•7 years ago
|
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/bbb3a6d41f922fb2aaf73e38948a4f1529755ac0
Fix Bug 1447752 - searchbox background color -> $white
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 3•7 years ago
|
||
[Tracking Requested - why for this release]: phlsa says "I’m a bit worried that this will look like it’s disabled to users, causing them to not search there." … "Then we just need to make sure that the fix also gets uplifted to beta"
tracking-firefox60:
--- → ?
Comment 4•7 years ago
|
||
Target Milestone: --- → Firefox 61
Comment 5•7 years ago
|
||
Please request Beta approval on this when you get a chance.
Flags: needinfo?(rrosario)
Comment 6•7 years ago
|
||
r1cky, we'll need a new patch for beta 60 as we probably won't uplift dark theme. Could you put together a PR against https://github.com/mozilla/activity-stream/tree/firefox-60
Updated•7 years ago
|
Flags: qe-verify+
Comment 7•7 years ago
|
||
Build ID: 20180402111808
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
I have verified that this issue is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest Nightly build (61.0a1) installed. Now the search bar color is displayed correctly.
Status: RESOLVED → VERIFIED
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8964379 [details]
Bug 1447752 - Search bar colour fill is wrong in Nightly.
https://reviewboard.mozilla.org/r/233094/#review238524
Attachment #8964379 -
Flags: review?(edilee) → review+
Comment 10•7 years ago
|
||
Comment on attachment 8964379 [details]
Bug 1447752 - Search bar colour fill is wrong in Nightly.
Approval Request Comment
[Feature/Bug causing the regression]: Undesired color set in bug
1418090
[User impact if declined]: Gray background instead of white could lead users to think searching is disabled
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, comment 7
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This needs to land after bug 1448394 just as an artifact of how we export changes.
[Is the change risky?]: No
[Why is the change risky/not risky?]: One line css change setting an explicit color. The exported change is large due to per-platform styles and source .map files, but the original source change is small: https://github.com/mozilla/activity-stream/commit/2c94813f73db427d3ffcbd47534cbd23731b7407
[String changes made/needed]: None
Flags: needinfo?(rrosario)
Attachment #8964379 -
Flags: approval-mozilla-beta?
Comment 11•7 years ago
|
||
Comment on attachment 8964379 [details]
Bug 1447752 - Search bar colour fill is wrong in Nightly.
activity stream regression fix, verified in nightly, approved for 60.0b10
Attachment #8964379 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•7 years ago
|
||
bugherder uplift |
Comment 13•7 years ago
|
||
I managed to reproduce the initial issue on 61.0a1 (2018-03-21). I can confirm that the 60.0b10 (20180404171943) build is verified fixed across platforms (Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13.3). The search bar is now properly displayed and its color is #FFF, in both normal and highlighted modes.
Flags: qe-verify+
Updated•7 years ago
|
User Story: (updated)
Updated•7 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•