After the last of the buildbot jobs are migrated to TC, there will be no need to support buildbot-bridge tasks in the taskgraph code.

Comment on attachment 8972987 [details] Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster https://reviewboard.mozilla.org/r/241534/#review247366 Passes the eyeball test. I'd love to see a try run to make sure general graph operations still work, and this may be worth a staging release as well. The staging release could happen before or after landing, as long as we don't uplift to beta before that happens.

Comment on attachment 8972987 [details] Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster https://reviewboard.mozilla.org/r/241534/#review247376 ::: taskcluster/docker/desktop1604-test/Dockerfile (Diff revision 1) > # Add utilities and configuration > COPY dot-files/config /builds/worker/.config > COPY dot-files/pulse /builds/worker/.pulse > RUN chmod +x bin/* > -# TODO: remove this when buildbot is gone > -COPY buildprops.json /builds/worker/buildprops.json I think this probably needs to stick around until we remove the buildbot-isms from mozharness. ::: taskcluster/taskgraph/morph.py:162 (Diff revision 1) > - dependencies=dependencies) > - task.task_id = parent_task.task['payload']['properties']['upload_to_task_id'] > - return task > - > - > def update_test_tasks(taskid, build_taskid, taskgraph): This function is part of the buildbot-bridge logic. The only caller is the next function, which you are removing.

(In reply to Aki Sasaki [:aki] from comment #2) > Comment on attachment 8972987 [details] > Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster > > https://reviewboard.mozilla.org/r/241534/#review247366 > > Passes the eyeball test. > I'd love to see a try run to make sure general graph operations still work, > and this may be worth a staging release as well. The staging release could > happen before or after landing, as long as we don't uplift to beta before > that happens. https://treeherder.mozilla.org/#/jobs?repo=try&revision=09d8807877176175a8c6421f25899a76a3d75390

Comment on attachment 8972987 [details] Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster https://reviewboard.mozilla.org/r/241534/#review247376 > I think this probably needs to stick around until we remove the buildbot-isms from mozharness. yeah, I thought so too, but tests seem to run fine without it...

Comment on attachment 8972987 [details] Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster https://reviewboard.mozilla.org/r/241534/#review247376 > yeah, I thought so too, but tests seem to run fine without it... I dug into this a bit. It looks like almost all the test pass `--no-read-buildbot-config` to mozharness, and those that don't post-date buildbot, so don't include `BuildbotMixin`. Thus, at least this image doesn't need the file anymore.

Comment on attachment 8972987 [details] Bug 1450029: Remove buildbot/buildbot-bridge references from taskcluster https://reviewboard.mozilla.org/r/241534/#review247428 (too many places to submit stuff in mozreview)

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00180532de61 Remove buildbot/buildbot-bridge references from taskcluster r=aki,tomprince