Part of the overall conversion to ReactJS. Estimated difficulty of 10

It might be worth doing bug 1438984 (switching to react-lazylog) at the same time as doing this.

The log viewer is spread across a few different files: https://github.com/mozilla/treeherder/blob/7fe8f9770380924566bacf9bdf78f208e970351e/ui/logviewer.html#L15-L130 https://github.com/mozilla/treeherder/blob/7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/components/logviewer/logviewer.js https://github.com/mozilla/treeherder/blob/7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/controllers/logviewer.js https://github.com/mozilla/treeherder/blob/2d85f9511bd91538cd4f92f73c98f8dee28e4011/ui/partials/logviewer/logviewer.html https://github.com/mozilla/treeherder/blob/2d85f9511bd91538cd4f92f73c98f8dee28e4011/ui/partials/logviewer/lvLogSteps.html https://github.com/mozilla/treeherder/blob/7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/directives/treeherder/log_viewer_steps.js Looking through them I wonder if we can not only cut out some of the functionality, but for anything that's still needed, try and re-use some of the lower level job-view's job details panel components? Also, if we end up switching this to react-lazylog, it might be worth using reactstrap rather than adding plain bootstrap usages that will then later need to be converted in bug 1497931.

(In reply to Ed Morley [:emorley] from comment #1) > It might be worth doing bug 1438984 (switching to react-lazylog) at the same > time as doing this. Yeah, I totally agree. Doing this now.

(In reply to Ed Morley [:emorley] from comment #2) > The log viewer is spread across a few different files: > > https://github.com/mozilla/treeherder/blob/ > 7fe8f9770380924566bacf9bdf78f208e970351e/ui/logviewer.html#L15-L130 > https://github.com/mozilla/treeherder/blob/ > 7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/components/logviewer/ > logviewer.js > https://github.com/mozilla/treeherder/blob/ > 7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/controllers/logviewer.js > https://github.com/mozilla/treeherder/blob/ > 2d85f9511bd91538cd4f92f73c98f8dee28e4011/ui/partials/logviewer/logviewer.html > https://github.com/mozilla/treeherder/blob/ > 2d85f9511bd91538cd4f92f73c98f8dee28e4011/ui/partials/logviewer/lvLogSteps. > html > https://github.com/mozilla/treeherder/blob/ > 7fe8f9770380924566bacf9bdf78f208e970351e/ui/js/directives/treeherder/ > log_viewer_steps.js > > Looking through them I wonder if we can not only cut out some of the > functionality, but for anything that's still needed, try and re-use some of > the lower level job-view's job details panel components? Agreed. Creating a shared JobInfo component for what you mentioned > Also, if we end up switching this to react-lazylog, it might be worth using > reactstrap rather than adding plain bootstrap usages that will then later > need to be converted in bug 1497931. Sounds good. Will do. :)

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/363dd0a1aa4a135a823607b55ad86661541e47e4 Bug 1450045 - Create a shared JobInfo component

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/3ad320d95888d7c201da4e5c08da1d08ac10782c Bug 1450045 - Convert Logviewer to ReactJS (#4223) And switch to using react-lazylog instead of unified-logviewer.