Open Bug 1451304 Opened 6 years ago Updated 2 years ago

Use Net panel connection for HAR export

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: Honza, Unassigned)

References

(Blocks 1 open bug)

Details

This is a follow up for bug 1436665

HAR export is currently using its own connection that doesn't fire actions - to avoid UI update, which slows down the export. This means that there might be two connections to the backend at the same time, each fetching the data. Not ideal.

The new connection for HAR is created in netmonitor/app.js module
Search for `getHarExportConnector`

This is the place where firing actions is disabled:
https://searchfox.org/mozilla-central/rev/a0665934fa05158a5a943d4c8b277465910c029c/devtools/client/netmonitor/src/har/har-exporter.js#199

One issue with sharing is the action disabling part. HAR export asynchronous and standard Net panel connection needs to fire actions. So, this part needs to be done differently...

It would be better to share the connection. But make sure that the UI is not updated when exporting HAR (it would slow down the export). Bug 1445617 suggest to also disconnect the HAR export connection from the store to get the best performance...

Honza
Depends on: 1436665
Priority: -- → P3
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.