Hi , I would like to work on it , can any one help me getting started!

Thanks

Bug 1520170 introduced a process for renaming a test in Perfherder. We'll need to make sure we do this once a patch to rename the test lands. In the code, this search should show the various places that will need to be updated. We'll also need to update the documentation and any consumers of this test's results, which includes the Firefox Health Dashboard.

Hi Shivam! Does comment 2 give you enough information to get started?

Hi Mike and Dave, thanks for the help, yeah I get to know what I need to do, I will ask if I have any doubt and send patch soon :)

Hi Dave , do i need to rename https://searchfox.org/mozilla-central/source/testing/talos/talos.json#29,

https://searchfox.org/mozilla-central/source/testing/talos/talos/unittests/test_config.py#666

https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#243 these as well?

Thanks. Just need clarifications about them then I will attach the patch :)

(In reply to Shivam Singhal [ :championshuttler ] from comment #5)

Hi Dave , do i need to rename https://searchfox.org/mozilla-central/source/testing/talos/talos.json#29,

Yes, "tps-e10s" should become "tabswitch-e10s" and "tps" should become "tabswitch"

https://searchfox.org/mozilla-central/source/testing/talos/talos/unittests/test_config.py#666

https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#243 these as well?

No, this is another test and it shouldn't be renamed.

Thanks. Just need clarifications about them then I will attach the patch :)

If you take a look at the results of this search but ignore the tpscrolltest hits, you'll see there are other places that we'll need to update. I also see a reference to testing/talos/talos/tests/tabswitch/tps.manifest, which should be renamed to tabswitch.manifest.

Once this is merged we will also need to update the docmentation and consumers such as the Firefox Health dashboard, as mentioned in comment 2. One impact of this is that we'll essentially have a new test in Treeherder and Perfherder, and the data from the old test will cease.

It is possible for us to rename the test signatures so that the past data matches the new test name, however from recent experience and some initial investigation into this specific test, it isn't a trivial task. If we do not rename, then any dashboards consuming the results for this test will need to continue to pull in the old test data for a consistent view of the results covering the rename.

Regardless of the historical test data being renamed, we'll have a window of approximately 1 day where we will not have alerts for regressions or improvements for this test. The performance sheriffs can look over the data and manually create alerts if they notice a change, but there is a small risk here.

:mconley would you require us to perform the historic rename on this test, or are you happy for the old name to fade into the past?

Good question.

Hey sphilp, dstrohmeier, except https://health.graphics/quantum/ do you know of any infrastructure that depends upon the tps test having the name "tps"? We were hoping to rename it here, but we want to ensure we don't break the world.

I am not aware of any other depending service, but I may not have the full overview here.

treeherder, perfherder, h.gfx is all that comes to mind. If there is something else, I suspect we'd be fine to find out after a rename. +1 to the rename in general, I always get this one confused :)

I've raised https://github.com/mozilla-frontend-infra/firefox-health-dashboard/issues/322 for the health.graphics dashboard.

https://hg.mozilla.org/mozilla-central/rev/fb0ffd7766a2