Ed Lee :Mardak Reporter
	Description • 7 years ago

From slack:

To do that, we’d need to uplift a small change to the `browser.newtabpage.activity-stream.feeds.section.topstories.options` pref.

This is the current default:
```{"api_key_pref":"extensions.pocket.oAuthConsumerKey","hidden":false,"provider_icon":"pocket","provider_name":"Pocket","read_more_endpoint":"https://getpocket.com/explore/trending?src=fx_new_tab","stories_endpoint":"https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=en-US","stories_referrer":"https://getpocket.com/recommendations","topics_endpoint":"https://getpocket.cdn.mozilla.net/v3/firefox/trending-topics?version=2&consumer_key=$apiKey&locale_lang=en-US","show_spocs":false,"personalized":true}```

The new default would be:
```{"api_key_pref":"extensions.pocket.oAuthConsumerKey","hidden":false,"provider_icon":"pocket","provider_name":"Pocket","read_more_endpoint":"https://getpocket.com/explore/trending?src=fx_new_tab","stories_endpoint":"https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=en-US&feed_variant=default","stories_referrer":"https://getpocket.com/recommendations","topics_endpoint":"https://getpocket.cdn.mozilla.net/v3/firefox/trending-topics?version=2&consumer_key=$apiKey&locale_lang=en-US","show_spocs":true,"personalized":true}```

let’s just make it clear in the bug that this enables sponsored content
but won’t show any until the server changes

	[github robot]
	Comment 1 • 7 years ago

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5f5872876ebd3fcbd7816e079cb34fccb2038620
feat(stories): Turn on sponsored content with new feed variant (#4102)

Fix Bug 1454807 - Turn on spocs by default with new variant endpoint

	Ed Lee :Mardak Reporter
	Comment 2 • 7 years ago

[Tracking Requested - why for this release]: This is desired from experiment results to turn on to 100% of population getting pocket stories.

	Ed Lee :Mardak Reporter
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

https://reviewboard.mozilla.org/r/237374/#review243182

	Ed Lee :Mardak Reporter
	Comment 6 • 7 years ago

To be clear, attachment 8968691 [details] is for mozilla-beta

	Ed Lee :Mardak Reporter
	Comment 7 • 7 years ago

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

Approval Request Comment
[Feature/Bug causing the regression]: Beta 60 Pocket experiments show we're good to turn it on for 100% of pocket in activity stream users for the rest of Beta 60 and Release 60
[User impact if declined]: Users would not get the experience of the desired experiment results
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: The changes depend on bug 1454743 and bug 1454790 landing first.
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: This is switching the default prefs to those that were used for the Beta 60 experiment
[String changes made/needed]: None

	Ed Lee :Mardak Reporter
	Comment 8 • 7 years ago

https://hg.mozilla.org/mozilla-central/rev/4183020e7017

	Ed Lee :Mardak Reporter
	Comment 9 • 7 years ago

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

Clearing as it sounds like more product decisions being made right now…

	[github robot]
	Comment 11 • 7 years ago

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/60107be6446aed067a7855684c9e878aec9ef25c
fix(stories): Enable for US region only (for en-* locales) (#4105)

Followup for bug 1454807

	Ed Lee :Mardak Reporter
	Comment 13 • 7 years ago
mozreview-review

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

https://reviewboard.mozilla.org/r/237374/#review243462

	Ed Lee :Mardak Reporter
	Comment 14 • 7 years ago

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

Approval Request Comment
[Feature/Bug causing the regression]: Pocket sponsored content was run as experiment in beta and turning on by default for 100% of US users who would see pocket stories (en-* locales)
[User impact if declined]: Users would not get the experience of the desired experiment results
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: The changes depend on bug 1454743 and bug 1454790 landing first.
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: This is switching the default prefs to those that were used for the Beta 60 experiment
[String changes made/needed]: None

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 7 years ago

Comment on attachment 8968691 [details]
Bug 1454807 - Turn on spocs by default with new variant endpoint

Approved for 60.0b14.

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/2d6338ce5318