Ricky Rosario [:rrosario, :r1cky] Assignee
	Description • 7 years ago

Section reordering broke how the spocs code gets sections from the SectionManager. This needs to be fixed asap and uplifted to 60 so the experiment can be run.

	Ed Lee :Mardak
	Comment 1 • 7 years ago

[Tracking Requested - why for this release]: This is breaking pocket sponsored content tests in beta 60

	[github robot]
	Comment 3 • 7 years ago

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/0130a1ee432e78fe71c4fbdeaa7c9d5918f5aa2a
Fix Bug 1454743 - fix section fetching in spocs experiment

https://github.com/mozilla/activity-stream/commit/e3d1716c70563da33af1a8d06665fecaa025fc06
Merge pull request #4100 from rlr/Bug1454743/fix-spocs

Fix Bug 1454743 - fix section fetching in spocs experiment

	Ed Lee :Mardak
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8968667 [details]
Bug 1454743 - spocs experiment is broken in 60+

https://reviewboard.mozilla.org/r/237340/#review243152

Thanks. This patch is for mozilla-beta

	Ed Lee :Mardak
	Comment 7 • 7 years ago

Comment on attachment 8968667 [details]
Bug 1454743 - spocs experiment is broken in 60+

Approval Request Comment
[Feature/Bug causing the regression]: Section reordering bug 1433212
[User impact if declined]: The remainder of the beta 60 pocket experiment and turning on by default in bug 1454807 would not work.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No, but this one blocks bug 1454790 and 1454807.
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Simple change fixing an assumed order for code that was only used for the experiment
1433212
[String changes made/needed]: None

	Ed Lee :Mardak
	Comment 8 • 7 years ago

https://hg.mozilla.org/mozilla-central/rev/4183020e7017

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 7 years ago

Comment on attachment 8968667 [details]
Bug 1454743 - spocs experiment is broken in 60+

Blocks the uplift of bug 1454790. Approved for 60.0b14.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/e3dba21f3bdf