+++ This bug was initially created as a clone of Bug #1444486 +++ Request is to have the product point to the /whatsnew page in the Firefox 60.0 release and show it (WNP) to the following locales: "locales": [ "an", "bg", "bs", "cak", "cs", "cy", "da", "de", "dsb", "en-US", "eo", "es-AR", "es-CL", "es-ES", "es-MX", "et", "fa", "fi", "fr", "fy-NL", "gu-IN", "hsb", "hu", "hy-AM", "id", "it", "ja", "ja-JP-mac", "ka", "ms", "nb-NO", "nl", "nn-NO", "pl", "pt-BR", "pt-PT", "ru", "sk", "sl", "sq", "sv-SE", "tr", "uk", "zh-CN", "zh-TW"

Note: the list of locales needs to be updated. Deadline for that is April 27. Can someone confirm that we're going to use this template? https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/whatsnew/whatsnew-fxa.html https://www-dev.allizom.org/firefox/59.0/whatsnew/

Michele - can you please confirm if it is the same scenario as in the 59 release? Fx user not logged into Fx Account is shown the FxAccount CTA Fx user logged into Fx Account is shown the Fx mobile CTA* *note that we will show the hardcoded mobile CTA page templates to zh-TW and id, which are being updated for 60.0

(In reply to Francesco Lodolo [:flod] from comment #1) > Note: the list of locales needs to be updated. Deadline for that is April 27. > > Can someone confirm that we're going to use this template? > https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/ > firefox/whatsnew/whatsnew-fxa.html > https://www-dev.allizom.org/firefox/59.0/whatsnew/ Because of the added states, I will be creating a new template. FWIW, the new template will look nearly identical to the template currently in use for 59 [1]. The new template will be located here: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/whatsnew/fx60/index.html Let me know which, if any, lang files I'll need to add to the new template. [1] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/whatsnew/whatsnew-fxa.html

:jpetto, from this doc https://goo.gl/qjSU6n, it looks like the strings are from https://www-dev.allizom.org/firefox/59.0/whatsnew/ and https://www-dev.allizom.org/firefox/mobile/

(In reply to Jon Petto [:jpetto] from comment #6) > Let me know which, if any, lang files I'll need to add to the new template. We need to import strings from 2 lang files. - firefox/whatsnew_59.lang - firefox/mobile.lang At risk of pointing out the obvious, we're also importing the ACTIVE status from firefox/mobile.lang. RelEng won't be enabling those locales, so it should be safe, but if someone manually opens the URL for one of those locales, it will show a page with mixed content.

Complete locales (51): an, bg, bs, cak, cs, cy, da, de, dsb, en-US, eo, es-AR, es-CL, es-ES, es-MX, et, eu, fa, fr, fy-NL, gn, gu-IN, hi-IN, hsb, hu, hy-AM, ia, it, ja, ja-JP-mac, ka, ko, lij, ms, nb-NO, nl, nn-NO, pl, pt-BR, pt-PT, ro, ru, sk, sl, sq, sr, sv-SE, tr, uk, zh-CN, zh-TW List for RelEng: { "locales": [ "an", "bg", "bs", "cak", "cs", "cy", "da", "de", "dsb", "en-US", "eo", "es-AR", "es-CL", "es-ES", "es-MX", "et", "eu", "fa", "fr", "fy-NL", "gn", "gu-IN", "hi-IN", "hsb", "hu", "hy-AM", "ia", "it", "ja", "ja-JP-mac", "ka", "ko", "lij", "ms", "nb-NO", "nl", "nn-NO", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sl", "sq", "sr", "sv-SE", "tr", "uk", "zh-CN", "zh-TW" ] }

Jon, does the website need to detect whether the user is logged into Fx Accounts? QA is noticing they're getting the page even if they're logged in.

(In reply to Aki Sasaki [:aki] from comment #10) > Jon, does the website need to detect whether the user is logged into Fx > Accounts? QA is noticing they're getting the page even if they're logged in. I'm not sure I understand the question. If QA is trying to test the URL [1] on prod right now, they'll get the page for 59.0.x, as the new code hasn't yet shipped to prod. If QA is testing the demo URL [2], then I'll need more info. :) [1] https://www.mozilla.org/firefox/60.0/whatsnew/ [2] https://www-demo4.allizom.org/en-US/firefox/60.0/whatsnew/ (Instructions for testing on the demo URL are in the PR - https://github.com/mozilla/bedrock/pull/5607)

Aki - can you please confirm the id (Indonesia) is not included in the locales being shown /whatsnew in 60? The page version for id is a hard-coded template, not in pontoon, so I think it was inadvertently left out of the list comment 9. Flod - both the id and zh-TW versions of /whatsnew are hard coded templates. id to promote only Rocket and zh-TW to promote Fx mobile (via QR code, only). While zh-TW as included in comment 9 I think that's due to the fact that the page has been localized in Pontoon, whereas the id page has not. So this may be where the fall off has occurred? Can you please assess?

The list was provided on April 26, a comment was added a few hours earlier in a different bug about Indonesian (https://bugzilla.mozilla.org/show_bug.cgi?id=1457024#c9), but the page was actually created on May 7 (https://bugzilla.mozilla.org/show_bug.cgi?id=1457024#c42). Not having 'id' in the list from comment 9 seems by design at this point, I have no way to track locales that have hard-coded templates. zh-TW is there because they translated the generic template, I wasn't aware they had a different page. Indonesian wasn't translated at the cut-off date, so it wasn't included in the list. https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/whatsnew_59.lang

(In reply to Eric Renaud [:erenaud] from comment #12) > Aki - can you please confirm the id (Indonesia) is not included in the > locales being shown /whatsnew in 60? > > The page version for id is a hard-coded template, not in pontoon, so I think > it was inadvertently left out of the list comment 9. > > Flod - both the id and zh-TW versions of /whatsnew are hard coded templates. > id to promote only Rocket and zh-TW to promote Fx mobile (via QR code, only). > > While zh-TW as included in comment 9 I think that's due to the fact that the > page has been localized in Pontoon, whereas the id page has not. So this may > be where the fall off has occurred? Can you please assess? Delay in reply is on me. Aki handed off releaseduty to me today. I can confirm that: - `id` is *not* in whatsnewpage list - `zh-TW` is in whatsnewpage list Full list that Balrog is currently using in production: { "fields": { "actions": "showURL", "openURL": "https://www.mozilla.org/%LOCALE%/firefox/60.0/whatsnew/?oldversion=%OLD_VERSION%" }, "for": { "channels": [ "release", "release-localtest", "release-cdntest" ], "locales": [ "an", "bg", "bs", "cak", "cs", "cy", "da", "de", "dsb", "en-US", "eo", "es-AR", "es-CL", "es-ES", "es-MX", "et", "eu", "fa", "fr", "fy-NL", "gn", "gu-IN", "hi-IN", "hsb", "hu", "hy-AM", "ia", "it", "ja", "ja-JP-mac", "ka", "ko", "lij", "ms", "nb-NO", "nl", "nn-NO", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sl", "sq", "sr", "sv-SE", "tr", "uk", "zh-CN", "zh-TW" ], "versions": [ "<60.0" ] I'll be around to adjust if you need. Please ping in slack or irc for fast turn around.

Eric confirmed over slack he wanted `id` added now to 60.0. I added it so it's live with 60.0 for <59.0 `id` based users who are upgrading.

Hello. I have tested WNP updates on 60.0.1 using "release-localtest" channel on (59.0-win64-pt-PT). After updating, the WNP appears to be the old one with the QR Code, rather than what is coming up on en-US build. I'll add an attachment with the pt-PT and en-US builds: https://drive.google.com/file/d/1ng80u_8dasTYwn2KxA9QZT6XddHPOx2A/view .

(In reply to Sasca Catalin, QA [:csasca] from comment #16) > Hello. I have tested WNP updates on 60.0.1 using "release-localtest" channel > on (59.0-win64-pt-PT). After updating, the WNP appears to be the old one > with the QR Code, rather than what is coming up on en-US build. I'll add an > attachment with the pt-PT and en-US builds: > https://drive.google.com/file/d/1ng80u_8dasTYwn2KxA9QZT6XddHPOx2A/view . I think this is a question for the bedrock team rather than Jordan.

Our /whatsnew templates have had multiple possible states for some time, and 60 is no exception. (Yes, this makes testing/QA rather laborious.) Here's the logic for 60.0 /whatsnew (taken from the code [1]): 1. User is not logged in to Sync (or UITour JS fails/times out): Display the FxA iframe 2. User is logged in to Sync, but does not have any mobile devices set up: Display App/Play store badges for Firefox Mobile i. Send to Device widget is available in the user's locale: Display the Send to Device widget ii. Send to Device widget is *not* available in the user's locale: Display a QR code for Firefox Mobile 3. User is logged in to Sync, and *does* have a mobile device set up: Display a QR code for Firefox Focus Display App/Play store badges for Focus My guess is that the browser used for testing in comment 16 is logged in to Sync with an account that does not have any mobile devices set up. This would result in the send to device widget being shown for en-US and the QR code displayed for pt-PT (as the send to device widget doesn't support that locale). If the browser used for testing in comment 16 has a different Sync status that what is assumed above, please let me know. [1] https://github.com/mozilla/bedrock/blob/master/media/js/firefox/whatsnew/whatsnew-60.js

Thanks for the your reply Jon. I think that we ran into this category here while running the update tests for pt-PT. (In reply to Jon Petto [:jpetto] from comment #18) > 2. User is logged in to Sync, but does not have any mobile devices set up: > Display App/Play store badges for Firefox Mobile > > ii. Send to Device widget is *not* available in the user's locale: > Display a QR code for Firefox Mobile This leads to another question now, is there a list of locales that don't have that widget available? It would help us in case we run into this again, and it could be a scenario to test as well. Also scenario 3 is also helpful for us as a scenario, we were not aware of that rule.

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #19) > This leads to another question now, is there a list of locales that don't > have that widget available? It would help us in case we run into this again, > and it could be a scenario to test as well. Yep, but the inverse - we keep a list of locales that *do* get the send to device widget. They are defined in our settings [1], and are currently: 'de', 'en-GB', 'en-US', 'en-ZA', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'fr', 'id', 'pl', 'pt-BR', 'ru', 'zh-TW' This list includes locales for which email (and possibly SMS) messages have been localized. The list of locales that can see the send to device widget can change based on marketing decisions. If folks in marketing decide to support another locale, or drop support for a locale, they notify us (the bedrock/moz.org dev team) and we update the list in our code. For testing/QA, the list in the settings/base.py file can be treated as complete, but should be checked at each testing/QA cycle to ensure the list has not changed. [1] https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L1202

(In reply to Jon Petto [:jpetto] from comment #20) > (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #19) > > This leads to another question now, is there a list of locales that don't > > have that widget available? It would help us in case we run into this again, > > and it could be a scenario to test as well. > > Yep, but the inverse - we keep a list of locales that *do* get the send to > device widget. They are defined in our settings [1], and are currently: > > 'de', 'en-GB', 'en-US', 'en-ZA', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'fr', > 'id', 'pl', 'pt-BR', 'ru', 'zh-TW' > > This list includes locales for which email (and possibly SMS) messages have > been localized. The list of locales that can see the send to device widget > can change based on marketing decisions. If folks in marketing decide to > support another locale, or drop support for a locale, they notify us (the > bedrock/moz.org dev team) and we update the list in our code. > > For testing/QA, the list in the settings/base.py file can be treated as > complete, but should be checked at each testing/QA cycle to ensure the list > has not changed. > > > [1] > https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L1202 This is great, thanks for the detailed information. Will make sure to check all this when doing more WNP testing.