Open
Bug 1455421
Opened 7 years ago
Updated 2 years ago
[meta] Standardize DevTools Panel initialization
Categories
(DevTools :: General, enhancement, P3)
Tracking
(firefox61 affected)
NEW
Tracking | Status | |
---|---|---|
firefox61 | --- | affected |
People
(Reporter: jdescottes, Unassigned)
References
(Depends on 3 open bugs, Blocks 1 open bug)
Details
(Keywords: meta)
Follow up to Bug 1455226.
To fix a toolbox destroy issue in Bug 1455226, we stopped loading the memory panel initializer.js file via a script tag. Instead it is now loaded via memory/panel.js. (see Bug 1455226 for more details about why this is needed)
This can potentially affect all panels, so we should apply a similar strategy everywhere. The goal of this bug is to prepare the work for this. Most likely:
- come up with a consistent pattern we can use in all tools
- submit it via a rfc
- once we have consensus, transform this bug in a meta and log bugs for each tool
Today most panels use a mix of code in {panel}.xhtml, a panel.js (loaded from definitions.js) and a initializer.js (loaded via a script tag in {panel}.xhtml) The pattern we come up with, should make this consistent, avoid relying on script tags, and hopefully reduce the dispersion of the init/destroy code of our panels.
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 1•6 years ago
|
||
Morphing this bug into a meta one to track progress of the conclusion made in the following RFC:
https://github.com/devtools-html/rfcs/issues/48
Which we could summarize as:
* rename index file to index.html (or xul/xhtml when relevant (bug 1470244)
* merge panel.js and initializer.js to panel.js
* Instanciate all BrowserLoader's from definitions.js
* Optional: remove or standardize the panel ready and destroyed events (bug 1443182)
Keywords: meta
Summary: Stop loading devtools code via script tags to avoid hangs during toolbox destroy() → [meta] Standardize DevTools Panel initialization
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•