Per the following RFC: https://github.com/devtools-html/rfcs/issues/48 And in order to unblock Promise.jsm removal and especially allow landing bug 1388054, we should refactor all document scripts like includes.js, controllers.js, views/*.js to be loaded as a module, via DevTools module loader.

Waiting for try results before asking for review... I tried to split this refactoring in multiple patches, but only manage to split out the switch from chrome: to resource: URLs. The rest had to include: * switch from script tags to browser loader modules * Instanciate a browser loader from definitions * use `exports.foo` everywhere and do the right require() everywhere to import symbols explicitely instead of relying on shared globals of script tags * merge inludes.js into panel.js, but also moved specifics to other modules, like findWhere into models * expose all symbols used by tests on panel and refactor tests to fetch them from panel instead of window If I refactor another panel as complex as web audio, I'll try to better split the changes if possible.

Comment on attachment 8988145 [details] Bug 1471567 - Move JS files from chrome to resource URL. https://reviewboard.mozilla.org/r/253396/#review260434

Comment on attachment 8988146 [details] Bug 1471567 - Standardize Web audio editor panel initialization. https://reviewboard.mozilla.org/r/253398/#review260438 Looks good, but clearing the r? based on our current discussion on the performance impacts of this kind of refactors. ::: devtools/client/webaudioeditor/panel.js:17 (Diff revision 2) > +const { gAudioNodes } = require("./nodes"); > +const { $, $$ } = require("./views/utils"); > +const { EVENTS } = require("./events"); > +const { MARKER_STYLING } = require("./views/context"); > +const { AutomationView } = require("./views/automation"); > +const { ContextView } = require("./views/context"); can we group this one with const { MARKER_STYLING } and have a single require?

The code behind DevTools:Web Audio Editor has gone away. Closing this bug as INVALID