Closed
Bug 1456322
Opened 7 years ago
Closed 7 years ago
On Android, Gesture activate documents on pointerup/touchend if there's been no touchmove/pointercancel
Categories
(Core :: DOM: Events, enhancement, P2)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(1 file)
On Android, we want to gesture activate documents if the user taps on something, but not if they scroll/pan.
How Chrome on Android does this is they gesture activate on pointerup. They send a pointercancel event if you touch and move too far, and don't send the pointerup when you lift your finger.
We don't support pointerevents on Android yet. We should do something similar to Chrome here, where we gesture activate on touchend if we've not observed a significant touchmove since the touchstart.
|
Assignee | |
Updated•7 years ago
|
Summary: On Android, Gesture activate documents on pointerup/touchstart if there's been no touchmove/pointercancel → On Android, Gesture activate documents on pointerup/touchend if there's been no touchmove/pointercancel
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971927 [details]
Bug 1456322 - Don't gesture activate documents on Android for touchends outside the drag threshold.
https://reviewboard.mozilla.org/r/240664/#review247750
::: commit-message-4607e:10
(Diff revision 1)
> +This means we won't gesture activate for touches that turn into scroll
> +gestures, but we will for touches that are taps.
nit: Could you explain the if block in NotifyTargetUserActivation() with this paragraph as comment?
Or, might be better to create an inline method like IsTouchEventTreatedAsScroll() or something which just calls IsEventOutsideDragThreshhold()? Then it makes clearer what the caller tries to check.
::: dom/events/EventStateManager.cpp:1853
(Diff revision 1)
> + static int32_t pixelThresholdX = 0;
> + static int32_t pixelThresholdY = 0;
nit: Could you use s prefix for them?
Attachment #8971927 -
Flags: review?(masayuki) → review+
| Comment hidden (mozreview-request) |
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/711118ca7f15
Don't gesture activate documents on Android for touchends outside the drag threshold. r=masayuki
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•