Closed
Bug 1505880
Opened 6 years ago
Closed 6 years ago
touchend event can't activate document incorrectly
Categories
(Core Graveyard :: Widget: Android, enhancement)
Core Graveyard
Widget: Android
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
(Whiteboard: [webcompat])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In bug1456322, we use `IsEventOutsideDragThreshold()` to check whether the touchend event is from dragging or touching at one point.
However, this method which is broken on Android always returns true, so we can't use this method to distinguish touch and drag.
The reason is that `mGestureDownPoint` is never set during draging, so everytime the distance we calculate in `IsEventOutsideDragThreshold()` would always larger than the threshold.
The `mGestureDownPoint` is set in `BeginTrackingDragGesture()` which is never called during dragging.
Updated•6 years ago
|
Component: DOM: Events → Event Handling
Comment 1•6 years ago
|
||
Why is BeginTrackingDragGesture not called? Is this Android widget level issue?
Ah, looks like so. Touch dragging is implemented on Windows only.
Component: Event Handling → Widget: Android
Assignee | ||
Updated•6 years ago
|
Summary: touchend event can't actiate document incorrectly → touchend event can't activate document incorrectly
Assignee | ||
Comment 2•6 years ago
|
||
We should set the 'mGestureDownPoint' correctly when receiving 'touchstart' so that we can
distinguish whether the 'touchend' comes from dragging or simply touching by calling
'IsEventOutsideDragThreshold()'.
Comment hidden (obsolete) |
Updated•6 years ago
|
See Also: → https://webcompat.com/issues/19018
Updated•6 years ago
|
See Also: → https://webcompat.com/issues/18303
Updated•6 years ago
|
Whiteboard: [webcompat]
Updated•6 years ago
|
Flags: webcompat?
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fbec497af48
set mGestureDownPoint when receiving 'touchstart' event. r=smaug
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•