Closed
Bug 1459891
Opened 7 years ago
Closed 6 years ago
Update public suffix list automatically once per cycle (from github)
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox-esr60 fixed, firefox64 fixed, firefox65 fixed)
RESOLVED
FIXED
People
(Reporter: jduell.mcbugs, Assigned: sfraser)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Right now we're manually updating the public suffix list (most recently in bug 1459882).
What I'd like to see next is a simple automated system where once per cycle we auto-grab
https://github.com/publicsuffix/list/blob/master/public_suffix_list.dat
and store it in the tree as
/netwerk/dns/effective_tld_names.dat
I talked to :gps about this and he said to file a bug in this component.
Update frequency: we're thinking to just do this update once per nightly cycle, fairly close to merge time. That way the list will get beta coverage but still not be too stale in release.
(Note: we have more ambitious plans to stop using a hardcoded-once-at-compile-time approach and use something closer to the phishing list approach where we update the list periodically--see bug 1083971--but that will be a while, so this is a good incremental step).
Reporter | ||
Comment 2•6 years ago
|
||
Just a nudge to see if this work can get on a schedule at some point.
Flags: needinfo?(gps)
Comment 3•6 years ago
|
||
This feels like something that could now be done with a Taskcluster hook.
That being said, if the frequency is once per cycle, I'm not sure it is worth automating. We may want to add it to the list of tasks performed when we cut new releases.
RyanVM: do you have any opinions?
Flags: needinfo?(gps) → needinfo?(ryanvm)
Comment 4•6 years ago
|
||
Could we add it as another periodic file update job like we do for addons blacklist, HSTS/HPKP pinning updates, etc? That runs twice a week at the moment.
Flags: needinfo?(ryanvm)
Comment 5•6 years ago
|
||
Simon, how easily could this be hooked up as part of the periodic file update?
Flags: needinfo?(sfraser)
Assignee | ||
Comment 6•6 years ago
|
||
I've got a draft patch ready. Does it only need to run against mozilla-central?
Flags: needinfo?(sfraser)
Comment 7•6 years ago
|
||
I don't see any reason we couldn't run these on Beta/ESR as well. What do you think, Daniel?
Flags: needinfo?(daniel)
Comment 8•6 years ago
|
||
Since the PSL reflects the state of the domains on the Internet *right now* I would agree that it makes sense to have as many as possible of our branches to adapt. I'm all for Beta/ESR too.
Flags: needinfo?(daniel)
Assignee | ||
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af5911ba3ef2
Routinely update in-tree TLD list r=RyanVM,jlorenzo
Comment 11•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Assignee: nobody → sfraser
Updated•6 years ago
|
Component: General → Release Automation: Other
Product: Developer Services → Release Engineering
QA Contact: sfraser
Updated•6 years ago
|
Comment 12•6 years ago
|
||
bugherder uplift |
Comment 13•6 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•