Closed Bug 1459991 Opened 6 years ago Closed 6 years ago

Embed natvis files from rust sysroot into xul.pdb

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 1408502 added a Gecko.natvis file and passed it to the libxul linker invocation so it'd get embedded in xul.pdb. The Rust compiler ships a few natvis files and will pass them to the linker when it generates binaries: https://github.com/rust-lang/rust/blob/b183bd0ad40b0188fc242bfb9f68a0cf1704dbd9/src/librustc_trans/back/linker.rs#L565 Since we don't link libxul with rustc we don't get this for free. We should add some machinery to locate these files and pass them to the linker. It'd probably be easiest to list them in moz.configure. For example, on my Windows machine: $ rustc --version rustc 1.24.1 (d3ae9a9e0 2018-02-27) $ ls $(rustc --print=sysroot)/lib/rustlib/etc intrinsic.natvis liballoc.natvis libcore.natvis
Version: Version 3 → 3 Branch
Assignee: nobody → ted
Rust ships with some natvis files that enable nicer display of Rust standard library types in Microsoft's debuggers. rustc will add the right linker options to include them when it invokes the linker but since we don't link libxul with rustc we need to explicitly pass them to the linker ourselves. This change locates all natvis files in the Rust sysroot and adds them to the libxul link line.
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33247481200e embed Rust's natvis files into xul.pdb on Windows. r=froydnj
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Blocks: 1618767
Regressions: 1632950
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: