Windows cross builds don't get rust natvis files linked in xul.pdb
Categories
(Firefox Build System :: General, defect, P3)
Tracking
(Not tracked)
People
(Reporter: glandium, Unassigned)
References
Details
The rust natvis files are not added to RUSTC_NATVIS_LDFLAGS, because the natvis files come with the host portion of the rust compiler, not the target, so they're only there with a Windows compiler.
I assume, from their content, that they are architecture-independent and that it's not a problem that the win32 and win64-aarch64 builds are using the natvis files from win64 rustc...
I assume, from their content, that they are architecture-independent and that it's not a problem that the win32 and win64-aarch64 builds are using the natvis files from win64 rustc...
The main concern would be pointer size, but it looks like everything's using *
instead of hardcoded values, so that should be fine.
The second concern would be if some struct decided to use a completely different layout per arch as an optimization. I'm assuming that's not happening since nobody has complained.
Comment 2•5 years ago
|
||
There's only a single set of natvis files in the Rust repo:
https://github.com/rust-lang/rust/tree/9ebf47851a357faa4cd97f4b1dc7835f6376e639/src/etc/natvis
Oh, shoot, I didn't see that this bug was talking about rust natvis, I thought it was about the gecko one.
Are things like this s8
ok on 32-bits? I don't speak natvis well enough to tell: https://github.com/rust-lang/rust/blob/9ebf47851a357faa4cd97f4b1dc7835f6376e639/src/etc/natvis/intrinsic.natvis#L4
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•2 years ago
|
Description
•