After we release new animation inspector, should remove old animation inspector related codes. We should check following files at least. * client/inspector/animation-old * client/inspector/inspector.js * client/preferences/devtools-client.js * server/actors/animation.js (e.g. bug 1454392 comment 40) * shared/fronts/animation.js * shared/specs/animation.js

Also, should remove player.animationIterationStartLabel variable in animationinspector.properties[1]. [1] https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/animationinspector.properties#76

And, telemetry code which is reflecting new animation inspector. [1] https://searchfox.org/mozilla-central/source/devtools/client/shared/telemetry.js#601

In this patch, remove main codes of old animation inspector such the inspector/animation-old directory. Additionally, remove the codes that had been referring the old codes. Also, remove a CSS variable which no longer reffered in inspector from devtools/client/themes/breadcrumbs.css, because this caused a test failure occur from browser/base/content/test/static/browser_parsable_css.js. In this patch, remove animationinspector.css as well. The reason why the error was not occurred so far is that it had been interpreted that animationinspector.css refer to the variable.

Depends on D5498

Depends on D5499

Depends on D5500

try: https://treeherder.mozilla.org/#/jobs?repo=try&author=dakatsuka@mozilla.com&fromchange=c47a95a285ad6a3ff9e77a83a2f07545c68f2c65

Comment on attachment 9007965 [details] Bug 1463621 - Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro Patrick Brosset <:pbro> has approved the revision.

Comment on attachment 9007966 [details] Bug 1463621 - Part 3: Rename application name. r=pbro Patrick Brosset <:pbro> has approved the revision.

Comment on attachment 9007968 [details] Bug 1463621 - Part 4: Remove no longer used variables in locale. r=pbro Patrick Brosset <:pbro> has approved the revision.

Comment on attachment 9007964 [details] Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro Patrick Brosset <:pbro> has approved the revision.

Comment on attachment 9007964 [details] Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro :Gijs (he/him) has approved the revision.

Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f05a37297647 Part 1: Remove main codes of old animation inspector. r=pbro,r=Gijs https://hg.mozilla.org/integration/mozilla-inbound/rev/46032e616f5d Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro https://hg.mozilla.org/integration/mozilla-inbound/rev/afcb44c66c5f Part 3: Rename application name. r=pbro https://hg.mozilla.org/integration/mozilla-inbound/rev/5d653605ce14 Part 4: Remove no longer used variables in locale. r=pbro

https://hg.mozilla.org/mozilla-central/rev/f05a37297647 https://hg.mozilla.org/mozilla-central/rev/46032e616f5d https://hg.mozilla.org/mozilla-central/rev/afcb44c66c5f https://hg.mozilla.org/mozilla-central/rev/5d653605ce14

Note that there is two leftovers: https://searchfox.org/mozilla-central/search?q=animation-old&case=false&regexp=false&path= This module seems to be no longer used: https://searchfox.org/mozilla-central/source/devtools/client/inspector/shared/dom-node-preview.js https://searchfox.org/mozilla-central/search?q=dom-node-preview&case=false&regexp=false&path=

Indeed! I had forgot to remove this. Thank you very much, Alexandre!