Closed
Bug 1490583
Opened 6 years ago
Closed 6 years ago
Remove actor related codes that were used from old animation inspector only
Categories
(DevTools :: Inspector: Animations, enhancement, P2)
DevTools
Inspector: Animations
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(1 file)
We have removed old animation inspector in bug 1463621 though, I had forgot to remove actor related codes.
In this bug, we will remove those codes from followings:
* server/actors/animation.js
* shared/fronts/animation.js
* shared/specs/animation.js
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9009023 [details]
Bug 1490583: Remove actor related code that no longer used. r=pbro
Patrick Brosset <:pbro> has approved the revision.
Attachment #9009023 -
Flags: review+
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44c69e043cf7
Remove actor related code that no longer used. r=pbro
|
||
Comment 5•6 years ago
|
||
Backed out changeset 44c69e043cf7 (Bug 1490583) for failures in browser_animation_reconstructState.js
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&selectedJob=199969880&revision=44c69e043cf72c43ccbde40cf99ea87f0ad1806a
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199969880&repo=autoland&lineNumber=5760
Backout: https://hg.mozilla.org/integration/autoland/rev/dc7813865b42a374563ad8ec320d5081cdbd93e5
Flags: needinfo?(dakatsuka)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Thanks Noemi,
I have reopened the phabricator.
https://phabricator.services.mozilla.com/D5842
Flags: needinfo?(dakatsuka)
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2aaa68300451
Remove actor related code that no longer used. r=pbro
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•