Closed
Bug 1466862
Opened 6 years ago
Closed 6 years ago
reftest analyzer not available for TVw (TV?) reftest failures
Categories
(Tree Management :: Treeherder: Frontend, defect, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gbrown, Assigned: camd)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=bb430edf217ece760c5fda5796d776f2256f90e3&selectedJob=181826461&filter-searchStr=TV
has reftest failures in TVw jobs (bug 1466740). The logs include the raw data needed for the reftest analyzer:
https://treeherder.mozilla.org/logviewer.html#?job_id=181826441&repo=mozilla-inbound&lineNumber=558-559
but the reftest analyzer button is not displayed in treeherder.
Is that possibly a problem for all TVw jobs with reftest failures? How about TV?
I don't know the cause of this problem. Possibly the log is in an unexpected format? Or does treeherder only offer the reftest analyzer for a whitelist of tasks?
Reporter | ||
Updated•6 years ago
|
Blocks: test-verify
Reporter | ||
Comment 1•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → gbrown
Reporter | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd0aa9fe8ba4c049bdf0a63d23fc51a0e427b32e seems to confirm that the reftest analyzer button is available if test-verify tasks are added to the "reftest" group. But I think that is inappropriate, since TV may run mochitests, xpcshell, etc.
:camd -- Can you take this bug, or find someone suitable?
I think it should be possible to include the reftest analyzer for jobs with 'test-verify' in their names, by modifying the conditions at:
https://github.com/mozilla/treeherder/blob/94100a23f0bf65df7f90b592653bcc01decfb5ae/ui/job-view/details/summary/ActionBar.jsx#L312
Component: General → Treeherder: Frontend
Flags: needinfo?(cdawson)
Product: Testing → Tree Management
Version: Version 3 → ---
Reporter | ||
Updated•6 years ago
|
Assignee: gbrown → nobody
Assignee | ||
Comment 3•6 years ago
|
||
Yes, I can take this. I'll get to it as soon as I can. I think it should be a pretty quick fix.
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Flags: needinfo?(cdawson)
Priority: -- → P2
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9057067 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4878
Sorry this took so long to get to. Hopefully better late than never... :)
Attachment #9057067 -
Flags: feedback?(gbrown)
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 9057067 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4878
Thanks, this looks great!
Attachment #9057067 -
Flags: feedback?(gbrown) → feedback+
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•