Closed
Bug 1469014
Opened 6 years ago
Closed 6 years ago
Port |Bug 1465866 - Remove methods from ScrollBoxObject|
Categories
(Calendar :: General, enhancement)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
6.4
People
(Reporter: jorgk-bmo, Assigned: mschroeder)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Looks like bug 1465866 is going ahead first. We need to replace getPosition() https://dxr.mozilla.org/comm-central/search?q=getPosition&redirect=false and getScrolledSize() https://dxr.mozilla.org/comm-central/search?q=getScrolledSize&redirect=false The latter is only used in im/ which is dead code and I will remove any minute now in bug 1410739. The former is used in calendar/ and im/ but Calendar/Lightning is currently not functioning, so any replacement would be hard to test. Boris and Emma, what else do we need to replace. If it's only this, I'll move the bug to Calendar.
Flags: needinfo?(emalysz)
Flags: needinfo?(bzbarsky)
![]() |
||
Comment 1•6 years ago
|
||
Those were the only things that I saw that needed replacing in comm-central.
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 3•6 years ago
|
||
Untested, but should work according to documentation.
Updated•6 years ago
|
Attachment #8985775 -
Flags: review?(philipp) → review+
Reporter | ||
Comment 4•6 years ago
|
||
(In reply to Martin Schröder [:martinschroeder] from comment #3) > Untested, but should work according to documentation. Just out of interest, can you please paste a link to the documentation. I was looking for attribute 'positionX' and didn't find anything.
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #4) > (In reply to Martin Schröder [:martinschroeder] from comment #3) > > Untested, but should work according to documentation. > Just out of interest, can you please paste a link to the documentation. I > was looking for attribute 'positionX' and didn't find anything. https://searchfox.org/mozilla-central/source/dom/webidl/ScrollBoxObject.webidl
Reporter | ||
Comment 6•6 years ago
|
||
Thanks: [Pure, Throws] readonly attribute long positionX; [Pure, Throws] readonly attribute long positionY; Then positionX.value looks wrong.
Flags: needinfo?(emalysz)
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8985775 [details] [diff] [review] Patch v1 The patch is wrong, see comment#6.
Attachment #8985775 -
Flags: review+ → review-
Assignee | ||
Comment 8•6 years ago
|
||
Attachment #8985775 -
Attachment is obsolete: true
Attachment #8986896 -
Flags: review?(jorgk)
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 8986896 [details] [diff] [review] Patch v2 Thanks. I'm not a Calendar peer, but since I spotted the problem, I think my r+ is acceptable here ;-)
Attachment #8986896 -
Flags: review?(jorgk) → review+
Comment 10•6 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/b59931d5608f Port bug 1465866: replace use of ScrollBoxObject.getPosition(). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•6 years ago
|
||
Looks like we didn't cover bug 1454358. So that's left to a new bug.
Summary: Port |Bug 1465866 - Remove methods from ScrollBoxObject| and |Bug 1454358 - Remove ScrollBoxObject| → Port |Bug 1465866 - Remove methods from ScrollBoxObject|
Target Milestone: --- → 6.4
Comment 12•6 years ago
|
||
Thanks for catching that Jörg!
You need to log in
before you can comment on or make changes to this bug.
Description
•