Closed
Bug 1469423
Opened 6 years ago
Closed 6 years ago
l10n bumper manual run during merge steps should have option to support DONTBUILD removed in commit message
Categories
(Release Engineering :: Release Automation: Other, enhancement)
Release Engineering
Release Automation: Other
Tracking
(firefox-esr60 fixed, firefox63 fixed)
RESOLVED
FIXED
People
(Reporter: jlund, Assigned: jcristau)
References
Details
(Whiteboard: [mergeduty])
Attachments
(1 file)
doing manual this cycle but be nice to have an option.
jlund> Jordan Lund RyanVM: so this l10n bumper stuff. we normally trigger aforced bumper run after merges:
14:49:17 https://github.com/mozilla-releng/releasewarrior-2.0/blob/9b226e7b8207bf84be153b2063434c8b02d4107a/docs/mergeduty/howto.md#run-the-l10n-bumper
14:49:30
<RyanVM> yes
14:49:46 and we need to make sure it's done w/o DONTBUILD so we can gtb off that push
14:50:00
<•jlund> Jordan Lund I can modify the script to remove DONTBUILD from commit message. Not sure how many commits we do and where, nor how often that runs but I'll comment it out for the forced run that I do
Reporter | ||
Updated•6 years ago
|
Whiteboard: merge-duty
Updated•6 years ago
|
Whiteboard: merge-duty → [mergeduty]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jcristau
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8986202 [details]
Bug 1469423 - add an option to let l10n-bumper trigger builds.
https://reviewboard.mozilla.org/r/251616/#review257970
Looks good to me. Even though the "build" -> "dontbuild" storage is slightly confusing a bit, the logic makes sense.
We'd need to update https://github.com/mozilla-releng/releasewarrior-2.0/blob/9b226e7b8207bf84be153b2063434c8b02d4107a/docs/mergeduty/howto.md#run-the-l10n-bumper to add the "--build" right?
Attachment #8986202 -
Flags: review?(mtabara) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8986202 [details]
Bug 1469423 - add an option to let l10n-bumper trigger builds.
https://reviewboard.mozilla.org/r/251616/#review257970
Yup, passing --build in addition to --ignore-closed-tree in the manual run after the merge from central should do it. Thanks for the review!
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/166bb5e00004
add an option to let l10n-bumper trigger builds. r=mtabara
Comment 5•6 years ago
|
||
https://github.com/mozilla-releng/releasewarrior-2.0/pull/154 is fixing the docs for the future.
Comment 6•6 years ago
|
||
bugherder |
Comment 7•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•