Closed Bug 1470227 Opened 6 years ago Closed 6 years ago

improve testing for bouncer submission task as it's a leaf node

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mtabara, Assigned: mtabara)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

a) We can add a follow-up API check to ensure the proper bouncer submission config values - - this ensures the service has been correctly updated b) Sanity checks that the values are correspondent to the specific tree / product Focusing on both. b) is something similar to what we've done in bug 1445684 for bouncer aliases task.
Currently tracking the bouncerscript PR here[1]. I might be doing the before-updating checks in the same PR since it's easier. [1]: https://github.com/mozilla-releng/bouncerscript/pull/25/
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1) > Currently tracking the bouncerscript PR here[1]. I might be doing the > before-updating checks in the same PR since it's easier. > > [1]: https://github.com/mozilla-releng/bouncerscript/pull/25/ First iteration works smoothly in terms of checking https://taskcluster-artifacts.net/Wzm9itGwRqeYfhR3NDO5og/0/public/logs/live_backing.log
This PR takes care of it + some other things along the way: * fix tests and brings coverage back to 100% * fix coveralls * add post-update-bouncer submission checks to ensure values reflect reality * add before-update-bouncer submission checks to ensure values are correctly set from tree and we're not submitting wrong information
Attachment #8989839 - Flags: review?(aki)
Attachment #8989839 - Flags: feedback?(sfraser)
Attachment #8989839 - Flags: review?(aki) → review+
Attachment #8989839 - Flags: feedback?(sfraser) → feedback+
Comment on attachment 8989839 [details] Improve bouncer submission as a leaf node by checking values before and after updating them Merged to master branch - https://github.com/mozilla-releng/bouncerscript/commit/a7f70202959d6c624de95a421e5b6eb464c4da7b and confirmed to be working with all products on maple. This will get to production with the upcoming bouncerscript bump.
Attachment #8989839 - Flags: checked-in+
This will get to production with the upcoming bouncerscript bump. Closing this for now as that's upcoming as soon as we land something similar in bug 1470226.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Rolled-out bump in bouncerscript production via https://github.com/mozilla-releng/build-puppet/pull/109/files
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: