Closed
Bug 1474341
Opened 6 years ago
Closed 6 years ago
Add AutoProfilerLabel to ScriptLoader::ProcessScriptElement
Categories
(Core :: Gecko Profiler, enhancement, P1)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•6 years ago
|
||
You can see the label frame here: https://deploy-preview-1072--perf-html.netlify.com/public/a377069a1ce0ccf369fec56cdb4135ac0be1a761/calltree/?hiddenThreads=3&search=ScriptLoader%3A%3AProcessScriptElement&thread=5&threadOrder=0-2-3-4-5-1&v=3
Again, it's not that useful right now since we can also see the XUL stack frame with same name but it will be useful when we are able to filter these stacks with "JS/C++ only" options.
|
||
Comment 3•6 years ago
|
||
Can you put the script URL in there and make it a dynamic label?
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•6 years ago
|
||
Added the script URL there. You can see the new frames here: https://deploy-preview-1072--perf-html.netlify.com/public/b90d1dee4e4e858f5ba0e3fe15a52682dfb2a81b/calltree/?hiddenThreads=2&search=ScriptLoader%3A%3AProcessScriptElement&thread=4&threadOrder=0-2-3-4-1&v=3
But this will require a patch in perf.html side because of the "share with/without network URLs" options. We have to strip them if they select share without network URLs.
|
|
Assignee | |
Comment 6•6 years ago
|
||
Actually that looks like a bigger problem because we have some other places that includes URLs. So we have to handle all of these cases. Filed an issue for that: https://github.com/devtools-html/perf.html/issues/1125
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8990745 [details]
Bug 1474341 - Add AutoProfilerLabel to ScriptLoader::ProcessScriptElement
https://reviewboard.mozilla.org/r/255808/#review264506
Attachment #8990745 -
Flags: review?(mstange) → review+
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f02d5dfeafac
Add AutoProfilerLabel to ScriptLoader::ProcessScriptElement r=mstange
|
||
Updated•6 years ago
|
Priority: -- → P1
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•