Closed Bug 1475998 Opened 6 years ago Closed 6 years ago

Add a clang x86 build

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Product:
Firefox Build System
Component:
General: Unsupported Platforms
Type:
enhancement

Tracking

(firefox-esr60 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj
(deleted), text/x-phabricator-request
Details
(I'll worry about this after x64 is landed.)
Depends on: 1490564
Depends on: 1490565
Depends on: 1490566
Depends on: 1490567
Depends on: 1490568
Depends on: 1490725
Depends on: 1491846
Depends on: 1491848
Depends on: 1491856
Attached file Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj (obsolete) (deleted) —
Comment on attachment 9010307 [details] Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj Nathan Froyd [:froydnj] has approved the revision.
Attachment #9010307 - Flags: review+
This commit also removes dwarf-exceptions from the x64 build. sjlj exceptions are needed on x86 because there is a bug currently involving SEH exceptions on x86. However on x64 there is not, so we can use the default SEH and get rid of dwarf exceptions.
Attachment #9010307 - Attachment is obsolete: true
> From your commit message, it sounds like fuse-cxa-atexit is only necessary for (native?) SEH handling. So we don't actually need this for x86, is that correct? If that's correct, should we just put fuse-cxa-atexit in WRAPPER_FLAGS for non-x86 targets only? As I understand it (Jacek and Martin know best) we want to use -fuse-cxa-atexit period. We (Mozilla) just never got around to adding it to our build script after Martin fixed it (IIRC?). But we do need to add it for SEH to work. Jacek do I have this right?
Flags: needinfo?(jacek)
-fuse-cxa-atexit is not strictly needed AFAIK. I added it in my WIP patch because Martin used it in his builds so that's a better tested config (and AFAIR that's what GCC config uses), but we may probably skip it if it's controversial.
Flags: needinfo?(jacek)
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df47d3ad9cc6 Add a x86 MinGW Clang Build Job r=froydnj
Keywords: checkin-needed
Found problem, fixed problem.
Flags: needinfo?(tom)
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28530a1156ce Add a x86 MinGW Clang Build Job r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/28530a1156ce
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: