Closed
Bug 1491856
Opened 6 years ago
Closed 6 years ago
Fix reflect mingw clang x86 compilation by changing .scl 3 -> 2
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
away
:
review+
lizzard
:
approval-mozilla-esr60+
|
Details |
Same change as Bug 1470993 except for x86
Assignee | ||
Updated•6 years ago
|
Component: General: Unsupported Platforms → XPCOM
Product: Firefox Build System → Core
Assignee | ||
Comment 1•6 years ago
|
||
As in Bug 1390583 and Bug 1470993, this will correct them to be external symbols
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor
David Major [:dmajor] has approved the revision.
Attachment #9009634 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb92888e989b
Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix the mingw-clang build for esr60
User impact if declined: Tor will have to carry this patch themselves, and we won't be able to run mingw-clang in automation.
Fix Landed on Version: 64.0a1 / 20180918075510
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The same fix was applied in esr60 in Bug 1470993 for x64 and had no problems.
String or UUID changes made by this patch:
Attachment #9009634 -
Flags: approval-mozilla-esr60?
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor
Low risk, useful for build automation, let's take this for ESR60.
Attachment #9009634 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
status-firefox-esr60:
--- → affected
tracking-firefox-esr60:
--- → 64+
Comment 7•6 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•