Closed Bug 1477280 Opened 6 years ago Closed 6 years ago

[skiplist] Add "exp2" to the skip list

Categories

(Socorro :: Signature, defect, P3)

Unspecified
Windows 10
defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
Tracking Status
firefox63 --- fixed

People

(Reporter: marcia, Assigned: sotaro)

References

Details

(Keywords: crash, regression, Whiteboard: [gfx-noted])

Crash Data

This bug was filed from the Socorro interface and is report bp-67d73764-de48-4267-a623-6e10b0180719. ============================================================= These Windows crashes started in the 20180717220130 build: https://bit.ly/2O5pKcI. While there are 8 crashes/9 installs, they don't appear to all be the same crash according to the Moz Crash Reasons: *assertion failed: new_cap >= self.len *assertion failed: !(ptr as *mut u8).is_null() *internal error: entered unreachable code: Found combinator Child in simple selectors vector? SelectorBuilder { simple_selectors: [ > , ._56_f, ._5d-3, ._3vjg, ._5dzz, ::before], combinators: [(Descendant, 1), (Descendant, 3), (PseudoElement, 1)], current_len: 1 } Do we need to add exp2 to the skip list? Here is what landed in that range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ed1506d1dc7db3d70a3feed95f1456bce05bbee&tochange=afa310dc89beeb4b7a9564d2c89ff32906f427ad Top 10 frames of crashing thread: 0 xul.dll exp2 1 xul.dll gfxWindowsPlatform::SchedulePaintIfDeviceReset gfx/thebes/gfxWindowsPlatform.cpp:926 2 xul.dll nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:1829 3 xul.dll void mozilla::RefreshDriverTimer::TickRefreshDrivers layout/base/nsRefreshDriver.cpp:299 4 xul.dll void mozilla::RefreshDriverTimer::Tick layout/base/nsRefreshDriver.cpp:317 5 xul.dll void mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver layout/base/nsRefreshDriver.cpp:671 6 xul.dll mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync layout/base/nsRefreshDriver.cpp:571 7 xul.dll mozilla::layout::VsyncChild::RecvNotify layout/ipc/VsyncChild.cpp:68 8 xul.dll mozilla::layout::PVsyncChild::OnMessageReceived ipc/ipdl/PVsyncChild.cpp:167 9 xul.dll void mozilla::ipc::MessageChannel::DispatchMessageW ipc/glue/MessageChannel.cpp:2064 =============================================================
talked with calixte a bit, and in looking at clouseau he suggested a ni on matt.
Flags: needinfo?(matt.woodrow)
I suspect this is also a change from Bug 1475660, where a change to the compiler results in different signatures. Adding exp2 to the skip list seems like the right idea.
Flags: needinfo?(matt.woodrow)
Hi guys, Set the component for this one to XUL since that was reported in the crash signatures, but feel free to change it to a more suitable component.
Component: General → XUL
Component: XUL → Graphics
Priority: -- → P3
(In reply to Matt Woodrow (:mattwoodrow) from comment #2) > I suspect this is also a change from Bug 1475660, where a change to the > compiler results in different signatures. > > Adding exp2 to the skip list seems like the right idea. If we want to add exp2 to skip list. This bug's "Product" needs to be "Socorro" like Bug 1364706 and Bug 1475482.
Component: Graphics → Signature
Product: Core → Socorro
Summary: Crash in exp2 → [skiplist] Add "exp2" to the skip list
Assignee: nobody → sotaro.ikeda.g
Whiteboard: [gfx-noted]
From bug #1477982: Example crash: bp-67d73764-de48-4267-a623-6e10b0180719 Current signature is "exp2", but if we moved forward from that, then we'd end with "gfxWindowsPlatform::SchedulePaintIfDeviceReset()" which is better.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
After that gets to prod, I'll reprocess the exp2 crash reports.
You need to log in before you can comment on or make changes to this bug.