Closed
Bug 1479973
Opened 6 years ago
Closed 6 years ago
Issues with login and using custom actions
Categories
(Tree Management :: Treeherder: Frontend, defect, P1)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nataliaCs, Assigned: camd)
References
Details
Attachments
(2 files)
Following the conversation #sheriffs with @camd
<camd> CosminS: nataliaCs|sheriffduty Aryx : Would any of you have some time to test Treeherder stage before we do a prod push? I re-wrote the top "PrimaryNavBar" recently.
9:48 PM So testing focused around that would be great.
treeherder starting being slower than usual, and there are two other issues noticed.
1. randomly being logged out - especially when accessing shared TH links - so a login was necessary again, through LDAP. After showing that the login was successful, a refresh of the page had to be done to really show that we are logged in.
2.Performing "custom actions" is not working, at all. Even though we are logged in, we cannot go on with the particular action, because it's asking to be logged in. Logged out, back in, refreshed, same issue. - i have attached a screenshot as well.
@camd - is there any chance you could take a look? I also checked the community status site and it seems like everything is operational. Thank you.
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(cdawson)
Comment 1•6 years ago
|
||
I can reproduce. Bisecting locally shows this started as of bug 1450030.
Updated•6 years ago
|
Summary: Treeherder Issues with logging and using custom actions → Issues with login and using custom actions
Assignee | ||
Comment 2•6 years ago
|
||
I think I see the problem. This should be a quick fix. Working on this now.
Flags: needinfo?(cdawson)
Assignee | ||
Comment 3•6 years ago
|
||
This was more than a quick fix, it ends up. Unfortunately the login issue is intermittent. I can't get it to reliably reproduce. And it seems harder to reproduce locally than on production. However, I can make a change that should make it more resilient. I'll test this on prototype shortly.
The issue with custom actions was just a bug where it was still trying to get to the ``user`` from ``$rootScope``. But we no longer store it in ``$rootScope`` so I needed to be passing it in. The fix is straightforward for that.
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8996801 -
Flags: review?(emorley)
Assignee | ||
Updated•6 years ago
|
Attachment #8996801 -
Flags: review?(sclements313)
Updated•6 years ago
|
Attachment #8996801 -
Flags: review?(emorley) → review+
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/f3641ab27ca3062c53b4b6f7c2213615358f90de
Bug 1479973 - Fix issues with login and using custom actions (#3866)
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cdawson
Updated•6 years ago
|
Attachment #8996801 -
Flags: review?(sclements313) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•