Closed
Bug 1483595
Opened 6 years ago
Closed 6 years ago
add NodeJS to the default build
Categories
(Firefox Build System :: General, enhancement, P1)
Firefox Build System
General
Tracking
(firefox63 fixed)
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
Set --enable-default in the build.
Creating a fresh bug for the patch that will be landed so that if people need to track down issues or bisect, they don't have to wade through all of the now-irrelevant stuff in bug 1464123.
The best summary of what's going on here, and what to do if this causes problems for you is:
https://docs.google.com/document/d/1SsFx5FDlY5JsM421opRM8nuWaTLMiqNZajrhsIL8jow/edit
Assignee | ||
Comment 1•6 years ago
|
||
And if that link should someday stop working, https://groups.google.com/d/msg/mozilla.dev.builds/RaeGCwcPYg8/BylibHAxCwAJ will likely still be valid.
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: AlKuz8BTKM3
Attachment #9001336 -
Flags: review?(gps)
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Same patch with an output message typo fixed.
MozReview-Commit-ID: AlKuz8BTKM3
Attachment #9001337 -
Flags: review?(gps)
Assignee | ||
Updated•6 years ago
|
Attachment #9001336 -
Attachment is obsolete: true
Attachment #9001336 -
Flags: review?(gps)
Assignee | ||
Comment 5•6 years ago
|
||
OK, based on the try-server output, I have a=ryanVM over IRC in #build to merge directly to mozilla-central. The plan is to do that first-thing Thursday morning Pacific time, so that I'll be around to help out if any issues occur.
I'll be sure to notify #sheriffs before doing the actual push.
Comment 6•6 years ago
|
||
Comment on attachment 9001337 [details] [diff] [review]
turn on NodeJS by default in the builds, v2
Review of attachment 9001337 [details] [diff] [review]:
-----------------------------------------------------------------
This seems reasonable. We may want to add some imply_option() in here so various build configurations that don't need Node don't require it. But we can do that as a follow-up. I think it is best to paint with a wide brush at this point in time so everyone deals with the transition now and we're not finding (as many) people with issues weeks or months down the line.
::: build/moz.configure/node.configure
@@ +66,5 @@
> +
> +If you believe this is a bug, <https://mzl.la/2vLbXAv> is a good way
> +to file. Executing `mach bootstrap --no-system changes` should
> +install a compatible version in ~/.mozbuild on most platforms.
> +More details: <http://bit.ly/2BbyD1E>
Please switch this to a https:// URL. I'd just drop the Google link instead of going through a shortener. But meh.
Attachment #9001337 -
Flags: review?(gps) → review+
Assignee | ||
Comment 7•6 years ago
|
||
http link switched to https
MozReview-Commit-ID: AlKuz8BTKM3
Assignee | ||
Updated•6 years ago
|
Attachment #9001337 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #9001679 -
Flags: review+
Pushed by dmosedale@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/cfbaf72d15f0
turn on NodeJS by default in the builds, r=gps, a=RyanVM
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
status-firefox63:
--- → fixed
Target Milestone: --- → mozilla63
Comment 9•6 years ago
|
||
Comment on attachment 9001679 [details] [diff] [review]
turn on NodeJS by default in the builds, v3
Review of attachment 9001679 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/moz.configure/node.configure
@@ +64,5 @@
>
> + MAYBE_FILE_A_BUG = '''
> +
> +If you believe this is a bug, <https://mzl.la/2vLbXAv> is a good way
> +to file. Executing `mach bootstrap --no-system changes` should
Shouldn't this be "--no-system-changes" (as a single arg)?
Comment 10•6 years ago
|
||
ni?:dmose for the apparent typo (see comment 9) in the message.
Flags: needinfo?(dmose)
Assignee | ||
Comment 11•6 years ago
|
||
Good catch, Jonathan! I just filed Bug 1484282, and will have a patch there shortly.
Flags: needinfo?(dmose)
You need to log in
before you can comment on or make changes to this bug.
Description
•