Closed Bug 1484018 Opened 6 years ago Closed 6 years ago

Nodejs requirement broke SearchFox

Categories

(Webtools :: Searchfox, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mccr8, Assigned: kats)

References

Details

Excerpt from the error log: 0:09.00 File "/index/mozilla-central/gecko-dev/python/mozbuild/mozbuild/configure/__init__.py", line 1003, in wrapped 0:09.00 return new_func(*args, **kwargs) 0:09.00 File "/index/mozilla-central/gecko-dev/build/moz.configure/node.configure", line 80, in nodejs_suitability 0:09.00 raise FatalCheckError(msg) 0:09.00 /index/mozilla-central/gecko-dev/build/moz.configure/checks.configure.FatalCheckError: could not find Node.js executable; ensure `node` or `nodejs` is in PATH or set NODEJS in environment to point to an executable. I'm guessing that bug 1483595 broke the SearchFox build.
That's undoubtedly the cause. Where are you seeing this? A tinderbox somewhere? If not, how can I reproduce?
Flags: needinfo?(continuation)
Note that if this is a local build using mozilla-central, "./mach bootstrap --no-system-changes" should install an appropriate version of Node into ~/.mozbuild that will make the problem go away.
(In reply to Dan Mosedale (:dmose) from comment #1) > That's undoubtedly the cause. Where are you seeing this? A tinderbox > somewhere? If not, how can I reproduce? SearchFox uses the mozsearch repo at https://github.com/mozsearch/mozsearch/ Reproducing it is... a bit involved but fortunately it looks like kats has fixed this.
Assignee: nobody → kats
Flags: needinfo?(continuation)
I built a new AMI with the change and kicked off a new indexing run with it. Assuming that works fine I'll merge the PR.
Wonderful; thanks so much, Kats!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.