Closed Bug 1484841 Opened 6 years ago Closed 3 years ago

Firefox for Android does some weird rounding/antialiasing on button corners (even for unthemed buttons)

Categories

(GeckoView :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 affected)

RESOLVED WORKSFORME
Tracking Status
firefox63 --- affected

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(2 files)

Unlike on every other platform, Firefox *for Android* seems to do a special rounding behavior of button border corners, even for unthemed buttons (i.e. buttons where the author has specified a custom background and/or border). This caused a decent amount of extra work (to diagnose/address an Android-only reftest orange) when I was to get Mihir's patch for bug 1397768 landed. (In the reftests in that bug's initial patch, there were various borders/backgrounds specified to help visualize different descendants of a button, and the key difference between reference case vs. testcase was that one file has various styles set on the button itself, whereas the other file had these styles set on a 100%-sized wrapper-div inside the button. This shouldn't have made a difference painting-wise for background/border, but it apparently does make a subtle difference right now, specifically on Android for the 4px grid at each corner of the button.) I've got a strawman reftest locally that demonstrates this issue -- I'll post that shortly, after I've confirmed that it's problematic via a Try run.
Here's a patch to add 2 reftests that demonstrate this issue. One test uses border, the other uses background -- but each of them is comparing the {border/background} being specified on a 100%-sized child of the button vs. on the button itself. Here's a multi-platform try run, showing that these reftests fail *only* on Android: https://treeherder.mozilla.org/#/jobs?repo=try&revision=93c403aab3bcab274832e1cf3ee23ebf1c2528ff&selectedJob=194943678
For posterity, here's the relevant snippet of the Android reftest log, suitable for pasting into https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml
Blocks: 1556282

Moving all open Core::Widget: Android bugs to GeckoView::General (then the triage owner of GeckoView will decide which ones are valuable and which ones should be closed).

Component: Widget: Android → General
Product: Core → GeckoView
Version: Trunk → unspecified

Emilio, do you know if this is still a problem? If it is, do you know who is the right team to look at it?

Flags: needinfo?(emilio)

This should be fixed, Android now has the same theme as other platforms.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(emilio)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: