Closed Bug 1556282 Opened 5 years ago Closed 5 years ago

Reliably-failing /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html

Categories

(Core :: CSS Parsing and Computation, defect, P5)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, regression)

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=249637132&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/T-usPOVvQoyEebc9DJsooA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/T-usPOVvQoyEebc9DJsooA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2019-06-02T23:20:53.550Z] 23:20:53 INFO - TEST-START | /css/css-contain/contain-layout-button-001.html
[task 2019-06-02T23:20:54.117Z] 23:20:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html
[task 2019-06-02T23:20:54.118Z] 23:20:54 INFO - REFTEST IMAGE 1

This failure is happening because we render buttons on Android with curved corners, even when a custom border has been specified. The reference case uses a div rather than a button, so it does not have those curved corners.

I recall running into this with other test failures before.

There may be a way to adjust the test to avoid this issue, but for now we could also just mark this test as fuzzy, since not very many pixels are differing.

Depends on: 1484841

Yeah, we should annotate this test as fuzzy, with a link to bug 1484841 as the reason for the fuzziness.

(technically it's not so much "fuzzy" but rather "a few pixels do actually differ due to our Android button rendering weirdness described in bug 1484841". But we can abuse fuzzy for this purpose in any case.)

Blocks: 1563334
Flags: needinfo?(dholbert)
Summary: Intermittent /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html → Reliably-failing /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html

The logcat log for the test failure in comment 0 says:

Found 12 pixels different, maximum difference per channel 191

I'll use that to craft a fuzzy annotation.

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aad99a661149
Annotate contain-layout-button-001.html as fuzzy rather than failing, on Android. (no review, test annotation only)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)

https://hg.mozilla.org/mozilla-central/rev/aad99a661149

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.