Closed
Bug 1487249
Opened 6 years ago
Closed 6 years ago
Add a PWindowGlobal actor corresponding to a single window global
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(3 files, 1 obsolete file)
This can be used as a base actor for per-frame cross-process communication.
Comment 1•6 years ago
|
||
Would it be for Window (inner) or for WindowProxy (outer) or something else?
Assignee | ||
Comment 2•6 years ago
|
||
These actors continue to use the ThreadLink link backend, which should
handle this situation well.
Assignee | ||
Comment 3•6 years ago
|
||
It seems when I added that code earlier, I missed this const.
Depends on D4620
Assignee | ||
Comment 4•6 years ago
|
||
This will be useful as a basis for asynchronous actors which would like to exist
both when crossing the process boundary (managed by PContent), and when
displaying an in-process window.
Depends on D4621
Assignee | ||
Comment 5•6 years ago
|
||
This actor can be used for communicating with individual frames, without
depending on walking the tree in the content process.
This is not yet complete. No tests have been written for it, the
WindowGlobalParent objects need to be exposed to chrome JS, and a form of JS
actors should be installed under them.
In addition, BrowsingContextChrome objects should be updated to allow access to
the current WindowGlobalParent in that context.
Depends on D4622
Comment 6•6 years ago
|
||
Comment on attachment 9005068 [details]
Bug 1487249 - Part 2: Add a missing 'const' to URIUtils.h
Andrew McCreight (busy) [:mccr8] has approved the revision.
Attachment #9005068 -
Flags: review+
Updated•6 years ago
|
Priority: -- → P2
Comment 7•6 years ago
|
||
Comment on attachment 9005070 [details]
Bug 1487249 - Part 3: Add the WindowGlobal actor representing a single window global
Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.
Attachment #9005070 -
Flags: review+
Comment 8•6 years ago
|
||
Comment on attachment 9005069 [details]
Bug 1487249 - Part 2: Add a new PInProcess actor to manage intra-thread actors
Andrew McCreight [:mccr8] has approved the revision.
Attachment #9005069 -
Flags: review+
Updated•6 years ago
|
Attachment #9005067 -
Attachment description: Bug 1487249 - Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8 → Bug 1487249 - Part 1: Allow MessageChannel objects to be created within a thread
Updated•6 years ago
|
Attachment #9005068 -
Attachment description: Bug 1487249 - Part 2: Add a missing 'const' to URIUtils.h, r=mccr8 → Bug 1487249 - Part 2: Add a missing 'const' to URIUtils.h
Updated•6 years ago
|
Attachment #9005069 -
Attachment description: Bug 1487249 - Part 3: Add a new PInProcess actor to manage intra-thread actors, r=mccr8 → Bug 1487249 - Part 3: Add a new PInProcess actor to manage intra-thread actors
Updated•6 years ago
|
Attachment #9005070 -
Attachment description: Bug 1487249 - Part 4: Add the WindowGlobal actor representing a single window global, r=bzbarsky → Bug 1487249 - Part 4: Add the WindowGlobal actor representing a single window global
Updated•6 years ago
|
Attachment #9005068 -
Attachment is obsolete: true
Comment 9•6 years ago
|
||
Comment on attachment 9005067 [details]
Bug 1487249 - Part 1: Allow MessageChannel objects to be created within a thread
Andrew McCreight [:mccr8] has approved the revision.
Attachment #9005067 -
Flags: review+
Updated•6 years ago
|
Attachment #9005069 -
Attachment description: Bug 1487249 - Part 3: Add a new PInProcess actor to manage intra-thread actors → Bug 1487249 - Part 2: Add a new PInProcess actor to manage intra-thread actors
Updated•6 years ago
|
Attachment #9005070 -
Attachment description: Bug 1487249 - Part 4: Add the WindowGlobal actor representing a single window global → Bug 1487249 - Part 3: Add the WindowGlobal actor representing a single window global
Comment 10•6 years ago
|
||
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/176131b18cb4
Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/8caf55928df2
Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/160a1dbe0be5
Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky
Comment 11•6 years ago
|
||
Backed out 9 changesets (bug 1500948, bug 1500949, bug 1448426, bug 1487249, bug 1500950, bug 1500944) for causing talos crashes on ts_paint | application crashed [@ MOZ_CrashOOL(char const*, int, char const*)]
Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/c12b84f575c3fe48d72f3c8c24a54b3dee1cc985
Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=429776feea6ba796345ef7e41b9c9d367335ef62
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213326943&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=213331977&repo=mozilla-inbound
:Nika Layzell Cold you please take a look?
Flags: needinfo?(nika)
Comment 12•6 years ago
|
||
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cd10aba9130
Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/0190d4ffa54f
Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c60fa11538db
Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(nika)
Comment 13•6 years ago
|
||
Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE
Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfe29337ffe3d93cd060077e2e999e72bb9b7cf
Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214255312&revision=c3fe435e473a463fbc22d4afa531bdedb757079c
Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=214255312&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214255794&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214249038&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=214249630&repo=mozilla-inbound
:Nika Layzell Could you please take a look?
Flags: needinfo?(nika)
Comment 14•6 years ago
|
||
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6604d042a96
Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba592aebdba2
Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1bb48d843f
Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(nika)
Comment 15•6 years ago
|
||
Backed out for causing bug 1485566 to permafail
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=215440693&revision=788d4d99984316782178133ba3bdab6b5742644a
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215440693&repo=mozilla-inbound&lineNumber=9094
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/62f498382b14816950a6568513354ecbabe05245
Flags: needinfo?(nika)
Comment 16•6 years ago
|
||
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8976adedb5cb
Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/222e2bcb25df
Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/20554da7b303
Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(nika)
Comment 17•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8976adedb5cb
https://hg.mozilla.org/mozilla-central/rev/222e2bcb25df
https://hg.mozilla.org/mozilla-central/rev/20554da7b303
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•