Closed Bug 1500948 Opened 6 years ago Closed 6 years ago

Expose BrowsingContext on nsFrameLoader

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Fission Milestone M4
Tracking Status
firefox65 --- fixed

People

(Reporter: nika, Assigned: nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This should make BrowsingContext more usable by making it much easier to obtain for a given frame or browser. BrowsingContext and nsFrameLoader should have the same lifetime. Depends on D9394
Priority: -- → P2
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fed1a518579a Expose BrowsingContext on nsFrameLoader objects, r=farre
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71c3b3677db8 Expose BrowsingContext on nsFrameLoader objects, r=farre
Flags: needinfo?(nika)
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/207746d120e9 Expose BrowsingContext on nsFrameLoader objects, r=farre
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/069d324080a5 Expose BrowsingContextId to IPDL correctly on a CLOSED TREE, a=bustage
Backed out for multiple crashes, e.g. in 914521.html backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e5174a6ca61076e60edb00fa4223818ecd0c2fc push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=069d324080a54edeb3b8d76b16c9fe85c33a1d3b failure log example: 11:00:02 INFO - REFTEST PROCESS-CRASH | file:///Users/cltbld/tasks/task_1543431328/build/tests/reftest/tests/docshell/base/crashtests/914521.html | application crashed [@ MOZ_CrashOOL(char const*, int, char const*)] 11:00:02 INFO - Crash dump filename: /var/folders/7y/h0rl3jcx0zx5cn4v3qgccryh00000w/T/tmpWryDON.mozrunner/minidumps/E5BF506E-236A-4220-A573-8BB081AB1911.dmp 11:00:02 INFO - Operating system: Mac OS X 11:00:02 INFO - 10.10.5 14F27 11:00:02 INFO - CPU: amd64 11:00:02 INFO - family 6 model 69 stepping 1 11:00:02 INFO - 4 CPUs 11:00:02 INFO - 11:00:02 INFO - GPU: UNKNOWN 11:00:02 INFO - 11:00:02 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS 11:00:02 INFO - Crash address: 0x0 11:00:02 INFO - Process uptime: 16 seconds 11:00:02 INFO - 11:00:02 INFO - Thread 0 (crashed) 11:00:02 INFO - 0 XUL!MOZ_CrashOOL(char const*, int, char const*) [Assertions.h:069d324080a54edeb3b8d76b16c9fe85c33a1d3b : 311 + 0x0] 11:00:02 INFO - rax = 0x0000000109e426b0 rdx = 0x00007fff792c11f8 11:00:02 INFO - rcx = 0x0000000000000000 rbx = 0x0000000107b3c86a 11:00:02 INFO - rsi = 0x00029a0000029a00 rdi = 0x0002990000029a03 11:00:02 INFO - rbp = 0x00007fff5f0a9520 rsp = 0x00007fff5f0a9510 11:00:02 INFO - r8 = 0x00007fff5f0a94c0 r9 = 0x00007fff7991d300 11:00:02 INFO - r10 = 0x00007fff881fe5d2 r11 = 0x00007fff881fe421 11:00:02 INFO - r12 = 0x000000010a062350 r13 = 0x000000011c9af108 11:00:02 INFO - r14 = 0x0000000000000134 r15 = 0x000000011a620060 11:00:02 INFO - rip = 0x000000010160a267 11:00:02 INFO - Found by: given as instruction pointer in context 11:00:02 INFO - 1 XUL!mozilla::ipc::LogicError(char const*) [ProtocolUtils.cpp:069d324080a54edeb3b8d76b16c9fe85c33a1d3b : 308 + 0x14] 11:00:02 INFO - rbp = 0x00007fff5f0a9530 rsp = 0x00007fff5f0a9530 11:00:02 INFO - rip = 0x000000010160d72b 11:00:02 INFO - Found by: previous frame's frame pointer 11:00:02 INFO - 2 XUL!mozilla::dom::PBrowserChild::SendRootBrowsingContext(mozilla::dom::IdType<mozilla::dom::BrowsingContext> const&) [PBrowserChild.cpp: : 2612 + 0xc] 11:00:02 INFO - rbp = 0x00007fff5f0a9590 rsp = 0x00007fff5f0a9540 11:00:02 INFO - rip = 0x00000001019d7505 11:00:02 INFO - Found by: previous frame's frame pointer 11:00:02 INFO - 3 XUL!mozilla::dom::TabChild::Init(mozIDOMWindowProxy*) [TabChild.cpp:069d324080a54edeb3b8d76b16c9fe85c33a1d3b : 592 + 0x5] 11:00:02 INFO - rbp = 0x00007fff5f0a9640 rsp = 0x00007fff5f0a95a0 11:00:02 INFO - rip = 0x000000010431a09e 11:00:02 INFO - Found by: previous frame's frame pointer 11:00:02 INFO - 4 XUL!mozilla::dom::ContentChild::ProvideWindowCommon(mozilla::dom::TabChild*, mozIDOMWindowProxy*, bool, unsigned int, bool, bool, bool, nsIURI*, nsTSubstring<char16_t> const&, nsTSubstring<char> const&, bool, nsDocShellLoadState*, bool*, mozIDOMWindowProxy**) [ContentChild.cpp:069d324080a54edeb3b8d76b16c9fe85c33a1d3b : 966 + 0xc] 11:00:02 INFO - rbp = 0x00007fff5f0a9a30 rsp = 0x00007fff5f0a9650 11:00:02 INFO - rip = 0x00000001042c68bd 11:00:02 INFO - Found by: previous frame's frame pointer
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f8c74fb660d Expose BrowsingContext on nsFrameLoader objects, r=farre
Flags: needinfo?(nika)
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5bab2966c5c6 Expose BrowsingContext on nsFrameLoader objects, r=farre
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Blocks: fission
Blocks: 1467227
Component: DOM → DOM: Core & HTML

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: