Closed Bug 1488168 Opened 6 years ago Closed 2 years ago

MRU tabs switching can switch to hidden tabs

Categories

(Firefox :: Tabbed Browser, defect, P5)

Product:
Firefox
Component:
Tabbed Browser
Version:
63 Branch
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: juraj.masiar, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Build ID: 20180830123124 Steps to reproduce: Now I'm pretty sure this is not by design - if you have some tabs hidden, you don't want to switch to them using "Ctrl + Tab" short-key. 1) enable MRU behavior (since 63 it's default??) 2) having one tab opened and one hidden 3) press "Ctrl + Tab" Actual results: Hidden tab is focused and not hidden anymore. Expected results: Hidden tabs should be excluded from "Ctrl + Tab" tabs switching. This affects only MRU!
Summary: New default Tabs behavior using MRU can switch to hidden tabs as well → New default Tabs switching behavior using MRU can switch to hidden tabs as well
Summary: New default Tabs switching behavior using MRU can switch to hidden tabs as well → MRU tabs switching (now default) can switch to hidden tabs!
Blocks: 1473595
Flags: needinfo?(dao+bmo)
Debatable whether this is a bug. I believe we deliberately had this behavior when panorama / tabview was still part of Firefox.
Blocks: ctrl-tab-panel
No longer blocks: 1473595
Status: UNCONFIRMED → NEW
Component: General → Tabbed Browser
Ever confirmed: true
Flags: needinfo?(dao+bmo)
Priority: -- → P3
Summary: MRU tabs switching (now default) can switch to hidden tabs! → MRU tabs switching can switch to hidden tabs
This behavior is not a good idea at all. First - it's not consistent with normal tabs switching which doesn't switch to hidden tabs Second - those tabs are hidden for a reason! My Group Speed Dial is using hidden tabs to create thumbnails - this bug now affects this feature and enables users to accidentally switch to the hidden tab, that has no purpose to them. Not to mention dozen other add-ons hiding tabs for any other reasons.
I can see how this can be problematic for add-ons, but not sure when I'd have time to look into this. If somebody else wants to take a look, the code is here: https://searchfox.org/mozilla-central/source/browser/base/content/browser-ctrlTab.js
Mentor: dao+bmo

Let me put in a few words.
Is it possible to make a couple of changes:

https://searchfox.org/mozilla-central/source/browser/base/content/browser-ctrlTab.js

line #346:
replace
if (aTab.closing)
to
if (aTab.closing || aTab.hidden)

line #569:
replace
Array.filter(gBrowser.tabs, tab => !tab.closing)
to
Array.filter(gBrowser.tabs, tab => !tab.closing && !tab.hidden)

All this can be done if the tab object has attribute hidden.
I did not conduct tests, maybe I did not take into account something.

Blocks: 1549623
Mentor: dao+bmo
Priority: P3 → P5

I don't see this happening anymore.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.