Closed
Bug 1490366
Opened 6 years ago
Closed 6 years ago
Convert about:addons pages to the card styles
Categories
(Toolkit :: Add-ons Manager, enhancement, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla64
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(4 files)
There are shared card styles for the keyboard shortcuts now. They work fairly well on the listing pages and are a nice improvement.
Once bug 1303384 is landed, we should update the listing pages to match the same style.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
I'm not seeing the pointer-events hack we talked about. Are you still going to implement that or did you find an alternative?
Flags: needinfo?(mstriemer)
Assignee | ||
Comment 5•6 years ago
|
||
I partially worked around it with CSS, it still isn't perfect, but good enough I think. The pointer-events hack didn't really work combined with the fix for the width of the richlistbox since you could only scroll while your mouse was over a richlistitem.
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e0abd16a50b
Part 1: Move card styles to common from about:debugging r=dao
https://hg.mozilla.org/integration/autoland/rev/448672780572
Part 2: Convert about:addons to card UI r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/0b8bcd97f254
Part 3: Select the first item in richlistbox on focus r=dao
Comment 7•6 years ago
|
||
Backed out 5 changesets (Bug 1488730, Bug 1490366, Bug 1488727) for bc failures in | toolkit/mozapps/extensions/test/browser/browser_details.js and browser/components/enterprisepolicies/tests/browser/browser_policy_disable_flash_plugin.js CLOSED TREE
Failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&selectedJob=205385796
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&selectedJob=205385130
Logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=205385130&repo=autoland&lineNumber=5583
https://treeherder.mozilla.org/logviewer.html#?job_id=205385437&repo=autoland&lineNumber=2358
Flags: needinfo?(mstriemer)
Assignee | ||
Comment 8•6 years ago
|
||
There was a bad rebase and a test change that should've been earlier in the series causing these failures. I'm running another try build now, but looks to be fixed and will re-land.
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a19f3794f0c9
Part 1: Move card styles to common from about:debugging r=dao
https://hg.mozilla.org/integration/autoland/rev/cb62a8b8a525
Part 2: Convert about:addons to card UI r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/0a45a5634cf1
Part 3: Select the first item in richlistbox on focus r=dao
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a19f3794f0c9
https://hg.mozilla.org/mozilla-central/rev/cb62a8b8a525
https://hg.mozilla.org/mozilla-central/rev/0a45a5634cf1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 11•6 years ago
|
||
Hi, what is part 3 about?
Does it mean that there will always be at least one item selected?
I thought in a seltype="multiple" it is possible to have no selection and no currentIndex.
See https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/richlistbox .
There does not seem to be any explanation in this bug.
Thanks.
Flags: needinfo?(mstriemer)
Assignee | ||
Comment 12•6 years ago
|
||
The currentIndex path hasn't changed, so I'm thinking not having a currentIndex was not possible before. Without part 3 focusing the richlistbox wouldn't mark a child as selected but pressing DownArrow to move to the first item would move to the second since currentIndex was already 1.
If you don't think this is how it should work can you please file a new bug and explain why you think it should change?
Flags: needinfo?(mstriemer)
Assignee | ||
Updated•6 years ago
|
Summary: Convert about:addons listing pages to the card styles → Convert about:addons pages to the card styles
Comment 14•6 years ago
|
||
Thanks, right. currentIndex was forced to other than -1 even before the patch, you just make the selection match the currentItem.
Comment 15•6 years ago
|
||
I was able to reproduce this issue on Firefox 62.0.3(20181001155545) under Win 7 64-bit and Mac OS X 10.13.3.
This issue is verified as fixed on Firefox 65.0a1(20181022220734) and Firefox 64.0b3 (20181022150107) under Win 7 64-bit and Mac OS X 10.13.3.
Please see the attached video.
You need to log in
before you can comment on or make changes to this bug.
Description
•