Closed
Bug 1500165
Opened 6 years ago
Closed 6 years ago
No gear menu in Recent Updates panel of new about:addons
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | verified |
firefox65 | --- | verified |
People
(Reporter: yfdyh000, Assigned: mstriemer)
References
Details
Attachments
(3 files)
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
(deleted),
video/quicktime
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
STR:
1. View Recent Updates in new about:addons.
2. Try to check for updates for add-ons.
Actual results:
No "check for updates" menu for now. I had to go to the other panel to use it and other menus of the gear menu and then return.
Expected results:
Allow to check for updates.
Assignee | ||
Comment 1•6 years ago
|
||
The gear was moved into the list view heading. Perhaps the list view heading should be part of the regular heading though.
Priority: -- → P2
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mstriemer
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56f06760024b
Include gear on each page of about:addons r=jaws
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9018396 [details]
Bug 1500165 - Include gear on each page of about:addons r?jaws
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1488730
User impact if declined: The gear menu in about:addons is hidden on some views, like the recent and available updates views.
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Moves markup for the gear menu out of list view, closer to where it was before.
String changes made/needed: None
Attachment #9018396 -
Flags: approval-mozilla-beta?
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•6 years ago
|
status-firefox63:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Comment 7•6 years ago
|
||
IMO this should have some verification if we're going to uplift. If not from automated tests, then manual QA.
Flags: qe-verify+
I managed to reproduce the issue using version 64.0a1 (20181018123730). Check for updates is not available on the Recent Updates page.
I retested using 65.0a1 (20181105100136) on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 x64 and the issue is fixed as the check for updates option is available on the Recent Updates page.
Flags: qe-verify+
Comment 9•6 years ago
|
||
Comment on attachment 9018396 [details]
Bug 1500165 - Include gear on each page of about:addons r?jaws
about:addons fix, approved for 64.0b8
Attachment #9018396 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•6 years ago
|
||
We encountered a conflict while trying to uplift:
warning: conflicts while merging toolkit/mozapps/extensions/content/extensions.xul! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
@mstriemer can you please provide a patch for beta? Thank you.
Flags: needinfo?(mstriemer)
Assignee | ||
Comment 11•6 years ago
|
||
Flags: needinfo?(mstriemer)
Assignee | ||
Comment 12•6 years ago
|
||
This patch should work on Beta.
Comment 13•6 years ago
|
||
bugherder uplift |
Comment 14•6 years ago
|
||
Verified as fixed using DevEdition 64.0b8 (20181108141956) on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 x64. The check for updates option is available on the Recent Updates page.
You need to log in
before you can comment on or make changes to this bug.
Description
•