Closed
Bug 1490703
Opened 6 years ago
Closed 6 years ago
Upgrade Mercurial clients to 4.7.1
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Infrastructure & Operations
RelOps: Puppet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sheehan, Assigned: dragrom)
References
()
Details
(Whiteboard: [stockwell disable-recommended])
Attachments
(3 files)
(deleted),
text/x-github-pull-request
|
sheehan
:
review+
|
Details |
(deleted),
text/x-github-pull-request
|
dhouse
:
review+
dragrom
:
checked-in+
|
Details |
(deleted),
patch
|
sheehan
:
review+
dragrom
:
checked-in+
|
Details | Diff | Splinter Review |
I noticed in https://tools.taskcluster.net/groups/fFnWZGmRS-WSkPXWqUo-jg/tasks/X7TB-SZBRiaZOuMI8-SGAQ/runs/0/logs/public%2Flogs%2Flive.log that the advertised Mercurial client version is only 4.4.1. We would like to get all Mercurial clients running in CI up to version 4.7.1, to take advantage of performance improvements.
Comment 1•6 years ago
|
||
on windows taskcluster workers, we've had good results using the msi installers (it's an easier patch for us than the .exe installers which have sometimes been problematic). we normally grab our installers from here: https://www.mercurial-scm.org/release/windows/. today it looks like the msi for 4.7.1 is not yet available.
we can quite easily/quickly upgrade to 4.7.0 (using https://www.mercurial-scm.org/release/windows/mercurial-4.7.0-x64.msi).
should we go ahead and upgrade to 4.7.0 or should we wait for the 4.7.1 msi release?
Reporter | ||
Comment 2•6 years ago
|
||
:grenade, we will need to wait for 4.7.1 to become available before upgrading Windows workers. 4.7.0 has a performance regression.
Assignee | ||
Updated•6 years ago
|
Assignee: relops → dcrisan
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
Created dmg package python27-mercurial-4.7.1-1.dmg for OSX 10.10 (yosemite) and copy it into repository
[root@releng-puppet2.srv.releng.mdc1.mozilla.com DMGs]# ll 10.10/
-rw-r--r-- 1 puppetsync puppetsync 2215936 Oct 14 2014 python27-mercurial-2.5.4-2.dmg
-rw-r--r-- 1 puppetsync puppetsync 2633728 Nov 25 2014 python27-mercurial-3.2.1-1.dmg
-rw-r--r-- 1 puppetsync puppetsync 3235840 Apr 6 2016 python27-mercurial-3.7.3-2.dmg
-rw-r--r-- 1 puppetsync puppetsync 3440640 Sep 13 2016 python27-mercurial-3.9.1-1.dmg
-rw-r--r-- 1 puppetsync puppetsync 4091904 Aug 15 2017 python27-mercurial-4.3.1-1.dmg
-rw-r--r-- 1 puppetsync puppetsync 4288512 Nov 16 2017 python27-mercurial-4.4.1-1.dmg
-rw-r--r-- 1 puppetsync puppetsync 5136384 Sep 13 06:51 python27-mercurial-4.7.1-1.dmg
Assignee | ||
Comment 4•6 years ago
|
||
Copied mercurial packages on repositories.
Installed new mercurial package on OSX staging workers:
[root@t-yosemite-r7-380.test.releng.mdc1.mozilla.com ~]# hg --version
Mercurial Distributed SCM (version 4.7.1)
Test new mercurial package on OSX workers:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5be4fb66a7726856bbce2853612df679ad65379d
Comment 5•6 years ago
|
||
these changes were deployed to windows beta workers earlier, where successful builds were validated using hg 4.7.1:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d339170
Attachment #9010526 -
Flags: review?(sheehan)
Assignee | ||
Comment 6•6 years ago
|
||
All jobs are green on OSX beta workers. hg 4.7.1 was validated on OSX
Assignee | ||
Comment 7•6 years ago
|
||
Installed new mercurial package on Ubuntu staging workers:
[root@t-linux64-ms-280 ~]# hg --version
Mercurial Distributed SCM (version 4.7.1)
(see https://mercurial-scm.org for more information)
Test new mercurial package on Ubuntu workers:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f989d07bd3f281c464e19e97b0be1a52df67c749
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
sent another push on try for Linux Workers:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4625533fbabda30da7781a74a695840b600208a4
Reporter | ||
Updated•6 years ago
|
Attachment #9010526 -
Flags: review?(sheehan) → review+
Assignee | ||
Comment 10•6 years ago
|
||
All jobs are green, hg 4.7.1 was validated in Ubuntu 16.04
Comment 11•6 years ago
|
||
windows patch was merged a few hours ago (https://github.com/mozilla-releng/OpenCloudConfig/commit/fb0c0f3dd021cee4c02c82feb3714ce38d0c2a82) and looks quiet too. clones are running normally.
Assignee | ||
Comment 12•6 years ago
|
||
Updated mercurial on Centos:
[root@relops-patching1.srv.releng.mdc1.mozilla.com ~]# hg --version
Mercurial Distributed SCM (version 4.7.1)
Assignee | ||
Comment 13•6 years ago
|
||
Upgrade mercurial to 4.7.1
Attachment #9011440 -
Flags: review?(jwatkins)
Attachment #9011440 -
Flags: review?(dhouse)
Attachment #9011440 -
Flags: review?(dhouse) → review+
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9011440 -
Flags: checked-in+
Assignee | ||
Updated•6 years ago
|
Attachment #9011440 -
Flags: review?(jwatkins)
Assignee | ||
Comment 15•6 years ago
|
||
Attachment #9013608 -
Flags: review?(sheehan)
Reporter | ||
Updated•6 years ago
|
Attachment #9013608 -
Attachment is patch: true
Attachment #9013608 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #9013608 -
Flags: review?(sheehan) → review+
Assignee | ||
Updated•6 years ago
|
Attachment #9013608 -
Flags: checked-in+
Assignee | ||
Comment 16•6 years ago
|
||
ooks like robustcheckout is not happy with hg 4.7.1. Here is the log:
[vcs 2018-10-02T12:36:59.844Z] Traceback (most recent call last):
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 161, in callcatch
[vcs 2018-10-02T12:36:59.844Z] return func()
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 344, in _runcatchfunc
[vcs 2018-10-02T12:36:59.844Z] return _dispatch(req)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 984, in _dispatch
[vcs 2018-10-02T12:36:59.844Z] cmdpats, cmdoptions)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 730, in runcommand
[vcs 2018-10-02T12:36:59.844Z] ret = _runcommand(ui, options, cmd, d)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 992, in _runcommand
[vcs 2018-10-02T12:36:59.844Z] return cmdfunc()
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 981, in <lambda>
[vcs 2018-10-02T12:36:59.844Z] d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1530, in check
[vcs 2018-10-02T12:36:59.844Z] return func(*args, **kwargs)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/local/lib/hgext/robustcheckout.py", line 255, in robustcheckout
[vcs 2018-10-02T12:36:59.844Z] sparse_profile=sparseprofile)
[vcs 2018-10-02T12:36:59.844Z] File "/usr/local/lib/hgext/robustcheckout.py", line 570, in _docheckout
[vcs 2018-10-02T12:36:59.844Z] assert util.versiontuple(n=2) in ((4, 3), (4, 4), (4, 5))
[vcs 2018-10-02T12:36:59.844Z] AssertionError
[vcs 2018-10-02T12:36:59.844Z] ** Unknown exception encountered with possibly-broken third-party extension robustcheckout
[vcs 2018-10-02T12:36:59.844Z] ** which supports versions 4.5 of Mercurial.
[vcs 2018-10-02T12:36:59.844Z] ** Please disable robustcheckout and try your action again.
[vcs 2018-10-02T12:36:59.845Z] ** If that fixes the bug please report it to the extension author.
[vcs 2018-10-02T12:36:59.845Z] ** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
[vcs 2018-10-02T12:36:59.845Z] ** Mercurial Distributed SCM (version 4.7.1)
[vcs 2018-10-02T12:36:59.845Z] ** Extensions loaded: share, rebase, strip, mq, purge, robustcheckout
[vcs 2018-10-02T12:36:59.845Z] Traceback (most recent call last):
[vcs 2018-10-02T12:36:59.845Z] File "/usr/bin/hg", line 41, in <module>
[vcs 2018-10-02T12:36:59.845Z] dispatch.run()
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 90, in run
[vcs 2018-10-02T12:36:59.845Z] status = dispatch(req)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 213, in dispatch
[vcs 2018-10-02T12:36:59.845Z] ret = _runcatch(req) or 0
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 354, in _runcatch
[vcs 2018-10-02T12:36:59.845Z] return _callcatch(ui, _runcatchfunc)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 362, in _callcatch
[vcs 2018-10-02T12:36:59.845Z] return scmutil.callcatch(ui, func)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 161, in callcatch
[vcs 2018-10-02T12:36:59.845Z] return func()
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 344, in _runcatchfunc
[vcs 2018-10-02T12:36:59.845Z] return _dispatch(req)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 984, in _dispatch
[vcs 2018-10-02T12:36:59.845Z] cmdpats, cmdoptions)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 730, in runcommand
[vcs 2018-10-02T12:36:59.845Z] ret = _runcommand(ui, options, cmd, d)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 992, in _runcommand
[vcs 2018-10-02T12:36:59.845Z] return cmdfunc()
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 981, in <lambda>
[vcs 2018-10-02T12:36:59.845Z] d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1530, in check
[vcs 2018-10-02T12:36:59.845Z] return func(*args, **kwargs)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/local/lib/hgext/robustcheckout.py", line 255, in robustcheckout
[vcs 2018-10-02T12:36:59.845Z] sparse_profile=sparseprofile)
[vcs 2018-10-02T12:36:59.845Z] File "/usr/local/lib/hgext/robustcheckout.py", line 570, in _docheckout
[vcs 2018-10-02T12:36:59.845Z] assert util.versiontuple(n=2) in ((4, 3), (4, 4), (4, 5))
[vcs 2018-10-02T12:36:59.845Z] AssertionError
Per irc:
yes, it needs to be updated. the new version is here https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/robustcheckout/__init__.py
Updated robustcheckout.py
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 18•6 years ago
|
||
Looks like now everything is OK:
https://tools.taskcluster.net/groups/DEozcJjBSVmjYcXIJxfW6g/tasks/XB0j5SLASRCH97OkQtAtIQ/runs/0/logs/public%2Flogs%2Flive.log
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot) |
Reporter | ||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•