Closed
Bug 1491212
Opened 6 years ago
Closed 6 years ago
Make Document.exitFullscreen() return a promise
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(4 files)
There is some non-trivial work to implement this on top of having requestFullscreen() return Promise, so I decide to spawn it into a separate bug from bug 1188256.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → xidorn+moz
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
The next patch would create another subclass of FullscreenChange for
handling fullscreen exit.
Depends on D5988
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D5989
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D5990
Updated•6 years ago
|
Priority: -- → P2
Comment 5•6 years ago
|
||
Comment on attachment 9009506 [details]
Bug 1491212 part 1 - Move PendingFullscreenRequestList to a higher place. r=smaug
Olli Pettay [:smaug] has approved the revision.
Attachment #9009506 -
Flags: review+
Comment 6•6 years ago
|
||
Comment on attachment 9009509 [details]
Bug 1491212 part 4 - Fix a wpt of exitFullscreen to check against the right Promise. r=smaug
Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009509 -
Flags: review+
Comment 7•6 years ago
|
||
Comment on attachment 9009508 [details]
Bug 1491212 part 3 - Have Document.exitFullscreen return a Promise. r=smaug
Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009508 -
Flags: review+
Comment 8•6 years ago
|
||
Comment on attachment 9009507 [details]
Bug 1491212 part 2 - Have a new FullscreenChange superclass split from FullscreenRequest. r=smaug
Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009507 -
Flags: review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12e1e7b2f4a7
part 1 - Move PendingFullscreenRequestList to a higher place. r=smaug
https://hg.mozilla.org/integration/autoland/rev/824f566f9043
part 2 - Have a new FullscreenChange superclass split from FullscreenRequest. r=smaug
https://hg.mozilla.org/integration/autoland/rev/32b021561f8c
part 3 - Have Document.exitFullscreen return a Promise. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b444a3e482d8
part 4 - Fix a wpt of exitFullscreen to check against the right Promise. r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13041 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/12e1e7b2f4a7
https://hg.mozilla.org/mozilla-central/rev/824f566f9043
https://hg.mozilla.org/mozilla-central/rev/32b021561f8c
https://hg.mozilla.org/mozilla-central/rev/b444a3e482d8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13041
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/aKOzgjrLRCG9H_HYX58ocQ)
Comment 15•6 years ago
|
||
Updated documentation as part of the big push on Fullscreen docs, and listed this change on Firefox 64 for developers.
https://developer.mozilla.org/en-US/docs/Web/API/Document/exitFullscreen
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•