The current behavior is confusing. Now that we've gotten rid of XPCOM addons, we can afford to change the behavior here. I'd also really love to get rid of wantXrays entirely, and have people use expanded principals when they want xrays from a sandbox. But that's a much riskier change that could break a lot of stuff, so I think we'll need to live with it.

Jim or ochameau, whoever gets to it first. MozReview-Commit-ID: 28cQgvxxl0E

MozReview-Commit-ID: CFpCiamhMBL

MozReview-Commit-ID: 9DrgknOT0Z3

When this lands, we'll want to remove the red box at https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Language_Bindings/Components.utils.Sandbox

(In reply to Bobby Holley (:bholley) from comment #0) > I'd also really love to get rid of wantXrays entirely, and have people use > expanded principals when they want xrays from a sandbox. But that's a much > riskier change that could break a lot of stuff, so I think we'll need to > live with it. I think we can actually just get rid of wantXrays at this point. We already use expanded principals everywhere it would have been necessary in the past. The remaining uses are pretty much just cargo culted, at this point.

(In reply to Kris Maglione [:kmag] from comment #6) > (In reply to Bobby Holley (:bholley) from comment #0) > > I'd also really love to get rid of wantXrays entirely, and have people use > > expanded principals when they want xrays from a sandbox. But that's a much > > riskier change that could break a lot of stuff, so I think we'll need to > > live with it. > > I think we can actually just get rid of wantXrays at this point. We already > use expanded principals everywhere it would have been necessary in the past. > The remaining uses are pretty much just cargo culted, at this point. Certainly worth a try, as a followup to this bug!

Comment on attachment 9009301 [details] [diff] [review] Part 2 - Mimic the old behavior in marionette. v1 Review of attachment 9009301 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. And I will follow-up on that workaround on bug 1274251 once this patch has been landed. Thanks!

Comment on attachment 9009300 [details] [diff] [review] Part 1 - Mimic the old behavior in devtools test. v1 Review of attachment 9009300 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. This test may also benefit from getting rid of wantXrays, it is quite hard to follow!

Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbbd1b11e09f Mimic the old behavior in devtools test. r=ochameau https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a8c0758631 Mimic the old behavior in marionette. r=whimboo https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc53ec73be9 Stop waiving the return value of the Sandbox constructor when wantXrays is false. r=kmag

https://hg.mozilla.org/mozilla-central/rev/fbbd1b11e09f https://hg.mozilla.org/mozilla-central/rev/a0a8c0758631 https://hg.mozilla.org/mozilla-central/rev/fcc53ec73be9

Red box removed as requested.